Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tiled gallery block: remove cropping #29600

Closed
wants to merge 1 commit into from
Closed

Tiled gallery block: remove cropping #29600

wants to merge 1 commit into from

Conversation

simison
Copy link
Member

@simison simison commented Dec 19, 2018 •
edited
Loading

Changes proposed in this Pull Request

  • Remove crop feature completely: it doesn't make sense in tiled gallery context where images should always be cropped to fit
  • Always set cropping on when transforming from Tiled gallery to core gallery

Testing instructions

@simison simison added [Goal] Gutenberg Working towards full integration with Gutenberg [Block] Tiled Gallery labels Dec 19, 2018
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=update/tiled-gallery-remove-crop

@simison simison requested a review from sirreal December 19, 2018 14:22
@simison simison mentioned this pull request Dec 19, 2018
Closed
@simison simison added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 19, 2018
@simison
Copy link
Member Author

simison commented Dec 27, 2018

Removed in #29559

@simison simison closed this Dec 27, 2018
@simison simison deleted the update/tiled-gallery-remove-crop branch December 27, 2018 11:16
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirreal sirreal Awaiting requested review from sirreal

Assignees
No one assigned
Labels
[Block] Tiled Gallery [Goal] Gutenberg Working towards full integration with Gutenberg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simison @matticbot