Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Home: Contextual "Update Your Homepage" Task #71277

Closed
Copons opened this issue Dec 16, 2022 · 5 comments
Closed

My Home: Contextual "Update Your Homepage" Task #71277

Copons opened this issue Dec 16, 2022 · 5 comments
Assignees

Comments

@Copons
Copy link
Contributor

Copons commented Dec 16, 2022

In the My Home checklist, one of the task prompts to "Update your homepage" with an "Edit site" CTA.

Copy and CTA should change depending on the theme.

For example:

  • Is it a legacy theme? Send to Customizer.
  • Is it a full-fledged FSE-enabled block theme providing a homepage template? Send to Site Editor, modifying the homepage template.
  • Is it an FSE-enabled theme without templates? Send to Page Editor for the homepage.

Note: please take a look at this comment that provides pointers to external resources and conversations about this issue.

Originally requested in #68953

@mmtr
Copy link
Member

mmtr commented Jan 12, 2023

Is it a legacy theme? Send to Customizer.

I'm not sure about this. Currently, for legacy themes, the task send users to the page editor for the homepage, and the card uses a different copy:

Screenshot 2023-01-12 at 15 50 13

IIRC, this task was added to change the homepage, not the site's design, so we should send users to the appropriate editor where they can update it.

So my suggestion is to apply these changes:

Legacy theme (e.g. Twenty Seventeen)

Item Current Proposed
Sidebar title Update your homepage N/A: same as currently
Card title Update your homepage N/A: same as currently
Description We've created the basics, now it's time for you to update the images and text. Make a great first impression. Everything you do can be changed anytime. N/A: same as currently
Action text Edit homepage N/A: same as currently
Action URL /page/<site-slug>/<homepage-id> N/A: same as currently

FSE theme (e.g. Twenty Twenty-Three) with a virtual homepage (front page = recent posts)

Item Current Proposed
Sidebar title Update your homepage N/A: same as currently
Card title Update your site's design Update your homepage
Description We've created the basics, now it's time for you to update the images and text. Make a great first impression. Everything you do can be changed anytime. N/A: same as currently
Action text Edit site Edit homepage
Action URL /site-editor/<site-slug> N/A: same as currently. The site editor opens by default the current homepage of the site.

FSE theme (e.g. Twenty Twenty-Three) without a virtual homepage (front page = static page)

Item Current Proposed
Sidebar title Update your homepage N/A: same as currently
Card title Update your site's design Update your homepage
Description We've created the basics, now it's time for you to update the images and text. Make a great first impression. Everything you do can be changed anytime. N/A: same as currently
Action text Edit site Edit homepage
Action URL /site-editor/<site-slug> /page/<site-slug>/<homepage-id>

@mmtr mmtr self-assigned this Jan 12, 2023
@mmtr
Copy link
Member

mmtr commented Jan 13, 2023

Posted pekYwv-vo-p2 to get some feedback about what's the best approach here.

@mmtr
Copy link
Member

mmtr commented Jan 17, 2023

These are the next steps according to the feedback discussed in pekYwv-vo-p2:

  • For legacy themes:
    • Keep the current “Update your homepage” wording.
    • Keep the current redirect to the page editor.
    • Keep the current behavior that hides the task if the homepage is set to show the latest posts.
    • Keep the current completion logic that requires the page content to be updated or the page_on_front option to be changed.
  • For block themes:
    • Keep the current “Update your site’s design” wording.
    • Keep the current redirect to the site editor.
    • Change the behavior to show the task if the homepage is set to show the latest posts.
    • Change the completion logic to mark the task as completed upon clicking on the CTA button (similarly to how the “Edit site design” task from the Launchpad is completed upon loading the site editor).

@mmtr
Copy link
Member

mmtr commented Jan 17, 2023

For block themes: [...] Change the behavior to show the task if the homepage is set to show the latest posts.

D98360-code

@mmtr
Copy link
Member

mmtr commented Jan 17, 2023

For block themes: [...] Change the completion logic to mark the task as completed upon clicking on the CTA button

#72224

@mmtr mmtr closed this as completed Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants