Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Donations: Use a heart as block icon #44796

Closed
mmtr opened this issue Aug 10, 2020 · 1 comment · Fixed by Automattic/jetpack#16880
Closed

Donations: Use a heart as block icon #44796

mmtr opened this issue Aug 10, 2020 · 1 comment · Fixed by Automattic/jetpack#16880
Assignees
@blackjackkent
Labels
[Block] Donations Donation block Earn [Type] Task

Comments

@mmtr
Copy link
Member

mmtr commented Aug 10, 2020

As shown in #42856, the block icon should be an outlined heart.

Seems we don't have the SVG code for that exact icon (discussed in p1597066567258400-slack-C0Q664T29) but one alternative could be to use the heart icon available in Gridicons or Material.

Gridicons Material
Screen Shot 2020-08-10 at 15 38 56 Screen Shot 2020-08-10 at 15 45 38
@blackjackkent blackjackkent self-assigned this Aug 10, 2020
@sixhours
Copy link
Contributor

I would advocate for using a Gridicon here rather than Material; we're probably going to move away from using Material icons in Calypso.

@blackjackkent blackjackkent mentioned this issue Aug 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blackjackkent blackjackkent

Labels
[Block] Donations Donation block Earn [Type] Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update donations block icon to heart gridicon Automattic/jetpack
3 participants
@mmtr @sixhours @blackjackkent