Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update donations block icon to heart gridicon #16880

Merged
merged 2 commits into from
Aug 20, 2020
Merged

Update donations block icon to heart gridicon #16880

merged 2 commits into from
Aug 20, 2020

Conversation

blackjackkent
Copy link
Contributor

Fixes Automattic/wp-calypso#44796

Changes proposed in this Pull Request:

  • This PR updates the icon displayed when selecting a donations block in the block editor, setting it to be a Gridicons outline heart.

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Set up a test site:
    • Create a JN site running this branch.
    • Go to /wp-admin/options-general.php?page=companion_settings.
    • Activate JETPACK_BETA_BLOCKS.
    • Set JETPACK__SANDBOX_DOMAIN with your sandbox address (make sure you enter the short URL e.g. mysandbox.wordpress.com to avoid issues with the SSL certificate).
  • Sandbox the API, the store and subscribe.wordpress.com (see PCYsg-lW4-p2 #sandbox-method for detailed instructions).
  • Set up Jetpack and purchase a Premium or Professional plan.
  • Go to Posts > New and add a donation block.
  • Verify that the block icon is a heart outline.

Proposed changelog entry for your changes:

  • Not needed.

@blackjackkent blackjackkent added the [Status] Needs Review This PR is ready for review. label Aug 18, 2020
@blackjackkent blackjackkent requested a review from a team August 18, 2020 20:46
@blackjackkent blackjackkent self-assigned this Aug 18, 2020
@jetpackbot
Copy link
Collaborator

jetpackbot commented Aug 18, 2020 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16880

Scheduled Jetpack release: September 1, 2020.
Scheduled code freeze: August 25, 2020

Generated by 🚫 dangerJS against f6e3061

jeherve
jeherve previously requested changes Aug 19, 2020
View reviewed changes
@jeherve jeherve added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Aug 19, 2020
@jeherve jeherve added this to the 8.9 milestone Aug 19, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello blackjackkent! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D48327-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@blackjackkent blackjackkent force-pushed the fix/donations-block-icon branch from d018f82 to f6e3061 Compare August 19, 2020 19:08
@blackjackkent
Copy link
Contributor Author

Updated per comment above! @jeherve

@blackjackkent blackjackkent added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Aug 19, 2020
mmtr
mmtr approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@mmtr mmtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Screen Shot 2020-08-20 at 10 54 26

Screen Shot 2020-08-20 at 10 54 36

@blackjackkent blackjackkent requested a review from jeherve August 20, 2020 15:58
dereksmart
dereksmart approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@dereksmart dereksmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test it, but the changes LGTM, and the prior review feedback looks to be addressed.

@dereksmart dereksmart dismissed jeherve’s stale review August 20, 2020 17:26

Feedback addressed

@blackjackkent blackjackkent merged commit 5a7fcde into master Aug 20, 2020
@blackjackkent blackjackkent deleted the fix/donations-block-icon branch August 20, 2020 18:20
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Needs Review This PR is ready for review. labels Aug 20, 2020
pereirinha pushed a commit that referenced this pull request Sep 10, 2020
@blackjackkent
[not verified] Update donations block icon to heart gridicon (#16880)
a487715
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmtr mmtr mmtr approved these changes

@dereksmart dereksmart dereksmart approved these changes

@jeherve jeherve Awaiting requested review from jeherve

Assignees

@blackjackkent blackjackkent

Labels
Touches WP.com Files
Projects
None yet
Milestone
8.9
Development

Successfully merging this pull request may close these issues.

Donations: Use a heart as block icon
6 participants
@blackjackkent @jetpackbot @matticbot @jeherve @mmtr @dereksmart