Signup: Remove invalid site_type parameter from verticals request (#3…

…3918)

Remove invalid site_type parameter from verticals request

Some flows do not choose a site type before requesting verticals from
the API (e.g. 'desktop'). If the site type hasn't been choosen then
don't send the site_type parameter as part of the request. The server
can then choose what the default site type should be.

client/state/data-layer/wpcom/signup/verticals/index.js

@@ -18,6 +18,8 @@ import { setVerticals } from 'state/signup/verticals/actions';
 import { SIGNUP_VERTICALS_REQUEST } from 'state/action-types';
 import { getSiteTypeId } from 'state/signup/steps/site-type/selectors';
 
+// Some flows do not choose a site type before requesting verticals. In this
+// case don't send a site_type param to the API.
 export const requestVerticals = action =>
 	http(
 		{
@@ -26,7 +28,7 @@ export const requestVerticals = action =>
 			path: '/verticals',
 			query: {
 				search: action.search.trim(),
-				site_type: action.siteTypeId,
+				...( action.siteTypeId && { site_type: action.siteTypeId } ),
 				limit: action.limit,
 				include_preview: true,
 			},

client/state/data-layer/wpcom/signup/verticals/test/index.js

@@ -34,6 +34,15 @@ describe( 'data-layer/wpcom/signup/verticals', () => {
 		);
 	} );
 
+	test( 'requestVerticals() with missing siteTypeId', () => {
+		const mockAction = {
+			search: 'Foo',
+			limit: 7,
+		};
+
+		expect( requestVerticals( mockAction ) ).not.toHaveProperty( 'query.site_type' );
+	} );
+
 	test( 'storeVerticals()', () => {
 		const search = 'Profit!';
 		const siteType = 'business';