-
Notifications
You must be signed in to change notification settings - Fork 360
Rainfall: address header and footer improvements #6305
Conversation
I added a commit to remove the link color from the header group as it was breaking the overlay colors. |
Nice, thanks! |
Thank you! Header and footer alignments and letter case look good.
I notice there's a tiny misplacement of the current menu item, is that the bug?
Thanks for opening that one!
Ok, let's leave it like that for now. I'm not sure this is the step to address this but the navigation links currently have no hover states. Those are specified here. |
Thanks @beafialho!
I think this is due to the font-weight. We could probably fix it by specifying a different line-height for the current item.. I can take a proper look into it.
Ah yeah, we can address this next! |
Changes proposed in this Pull Request:
This addresses most of the feedback in #6245.
I haven't been able to address all of it as I've tried to stick with what's currently available from GB, but let me know if we should manually add anything.
Header and footer are now full width
Footer text is now uppercase by default (I also made the links a navigation block)

Styled the mobile menu further:
We are currently able to swap the hamburger menu for text that says 'menu', but there is currently no option for replacing the 'X' with text (issue here: WordPress/gutenberg#42848).
This is how the overlay looks now:

I haven't included the social menu in the overlay as this currently isn't possible in GB (I don't think?)
I've also styled the current menu item, but it looks like there's a bug with the
current-menu-item
class. Fix here: WordPress/gutenberg#42849Related issue(s):
#6245