Skip to content
This repository has been archived by the owner on Feb 17, 2025. It is now read-only.

Curator: add paragraph with quote block pattern #6090

Merged
merged 3 commits into from
Jun 28, 2022

Conversation

jffng
Copy link
Contributor

@jffng jffng commented Jun 15, 2022

Changes proposed in this Pull Request:

Adds Paragraph with Right Aligned Quote block pattern.

Screen Shot 2022-06-15 at 11 59 46 AM

Related issue(s):

Part of #5935

@jffng jffng added the [Theme] Vivre Automatically generated label for Vivre. label Jun 15, 2022
@jffng jffng requested a review from a team June 15, 2022 16:00
@jffng jffng mentioned this pull request Jun 15, 2022
8 tasks
@madhusudhand
Copy link
Contributor

Set the font-weight of quote to 500 and tagline to 300.

And in smaller media, space above the quote could reduce and needs some padding below the quote to separate it from next paragraph.

image

@jffng
Copy link
Contributor Author

jffng commented Jun 28, 2022

Set the font-weight of quote to 500 and tagline to 300.

👍

And in smaller media, space above the quote could reduce and needs some padding below the quote to separate it from next paragraph.

I added a 20px spacer in the last column to address this.

@jffng jffng added the [Status] Needs Design Approval This task needs a designer to approve the changes before it can be merged or marked complete. label Jun 28, 2022
@jffng
Copy link
Contributor Author

jffng commented Jun 28, 2022

cc @beafialho this is ready for your review.

@beafialho
Copy link
Collaborator

This looks good as well!

@jffng jffng merged commit 1680d39 into trunk Jun 28, 2022
@jffng jffng deleted the add/curator-paragraph-quote-pattern branch June 28, 2022 15:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Status] Needs Design Approval This task needs a designer to approve the changes before it can be merged or marked complete. [Theme] Vivre Automatically generated label for Vivre.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants