This repository has been archived by the owner on Feb 17, 2025. It is now read-only.
Skatepark: refactor patterns to load directly from the editor #5858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
mikachan
reviewed
Apr 14, 2022
There was a problem hiding this comment.
This is looking good and the implementation works well. I've just left a few comments about the pattern categories. I'm not sure we should have so many listed in 'Featured', and I think there are a couple that use images that we could add to a new 'Images' category.
madhusudhand
force-pushed
the
skatepark-refactor-patterns
branch
from
84c39d0 to
f9387d0
Compare
|
I see all of @mikachan 's comments have been resolved. Looks good to me. 🚢 |
pbking
approved these changes
Apr 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Validate patterns both in inserted and in template parts.
Related issue(s):
Fixes #5803 for Skatepark.