-
Notifications
You must be signed in to change notification settings - Fork 360
Add and configure fonts for use in Pendant. #5700
Conversation
Thanks @pbking! A few comments:
I think this can work fine, but wanted to know which size did you set for H5? |
@beafialho I have changed all of the Literata to Light instead of Extra Light. Literata is a pretty large typeface (~230k/per) so if that works for all sizes that would be a win. That said the Italics typeface is pretty different and that seems more worth the cost. I've added that. Let me know what you think. I don't have a 72pt variety in what I downloaded. 60pt is what I found available and have been using. If you have another resource I should use instead LMK. I've adjusted the smaller headings to use Jost Medium and adjusted the letter spacing. The sizes for H5: I've updated the screenshots. This is ready for another look. |
Thanks @pbking. Awhile back when I downloaded the font from Google Fonts, it came with the 72pt version. It must have removed in the meantime, but we can use this one instead. At the moment I'm still seeing H6 without the letter spacing, can you double check? The one above is the default, and below is the correct letter spacing. Regarding the mobile heading sizes, let's use the sizes below. I updated the Figma styles. |
Yup, I absolutely skipped H6's letter spacing. Corrected.
Values tweaked to match. And thank you for providing the 72pt version. I dropped that in. Screenshots updated. @beafialho it's ready for another review. |
Thank you, I think these are all looking accurate 👍 |
Oh sorry @pbking, I hadn't seen this! We can use the Bold weight instead, I prefer to change the title than the headings. Also, the Bold Italics in your screenshot don't seem to match the font. Here's how the headings should look with the Bold one: |
Yes, thanks! |
Changes proposed in this Pull Request:
Add necessary font files to /assets/fonts
Add entries for fonts in theme.json
Configure headings and body element attributes in theme.json
Ensure user-selectable font sizes are appropriate
Review for mobile/desktop size scaling
Note that most of this task doesn't seem to be do-able in the FSE. Management of fonts is expected to be possible with 3rd party plugins or perhaps JetPack.
Details:
In order to achieve the design the typefaces Jost-Light and Literata-ExtraLight have been used.
The original design notes a size difference between desktop/mobile for header font sizes. This is achieved with
clamp()
values.The original design notes that the typeface for Heading 4 (and presumeably 5) change from Literata to Jost from Desktop to Mobile. This isn't possible with current tooling without CSS. I've split the difference and made H5 and H6 uppercase Jost. Please let me know if this is acceptable.
Related issue(s):
Fixes: #5676
Screenshots:
Headings (desktop):
Headings (mobile):
Body (desktop):
Body (mobile):
Used for evaluation: