This repository has been archived by the owner on Feb 17, 2025. It is now read-only.
Quadrat: Add padding to full align column and group blocks #3890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
changed the title
jffng
reviewed
May 20, 2021
| @@ -202,8 +202,8 @@ | |||
| }, | |||
| "post-content": { | |||
| "padding": { | |||
| "left": "var(--wp--custom--margin--horizontal)", | |||
| "right": "var(--wp--custom--margin--horizontal)" | |||
| "left": "0px", | |||
There was a problem hiding this comment.
I understand why you want to remove this, so that content can extend the full width. But it causes all of the blocks (including text) to start at the edge of the screen:
This was
linked to
issues
May 20, 2021
|
What should happen here? How does this PR relate to #3816? |
|
Closing in favour of #3953 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This is a different approach to #3816.
The approach is much simpler - we just add padding to the column and group blocks when they are fully aligned. This also requires us to remove the padding from the post content block.
Related issue(s):
#3747