Skip to content
This repository has been archived by the owner on Feb 17, 2025. It is now read-only.

Multiple Themes: Clean up top margin when header & homepage title are hidden #3071

Merged
merged 2 commits into from
Jan 20, 2021

Conversation

kjellr
Copy link
Contributor

@kjellr kjellr commented Jan 20, 2021

Followup from #2961.

When both the "Hide Header" and "Hide Homepage Title" settings are activated, many of Varia's child themes needed some slight adjustments to ensure:

  • That the first child block of entry-content had top margin, and didn't bump up against the top of the screen.
  • That certain full-width blocks do properly bump up against the top of the screen.

The fix was generally just to:

  • Add a rule to Varia to ensure that the top margin is present by default.
  • Recompile CSS for all of the child themes.
  • Add special case margins for themes that use non-standard margins (Shawburn, Rockfield, Morden, Redhill).

Screenshots

Generally, this is what things looked like before, using Barnsbury (on the left) and Stow (on the right) as examples:

Before

Full-width Media/Text Block Paragraph
Screen Shot 2021-01-20 at 11 44 53 AM Screen Shot 2021-01-20 at 11 48 02 AM

After

Full-width Media/Text Block Paragraph
Screen Shot 2021-01-20 at 11 39 52 AM Screen Shot 2021-01-20 at 11 48 25 AM

@kjellr kjellr added [Type] Bug Something isn't working [Theme] Varia labels Jan 20, 2021
@kjellr kjellr requested a review from a team January 20, 2021 16:50
@kjellr kjellr self-assigned this Jan 20, 2021
Copy link
Member

@scruffian scruffian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scruffian scruffian merged commit 0414d0c into trunk Jan 20, 2021
@scruffian scruffian deleted the multiple-themes/fix-spacing-with-no-header branch January 20, 2021 17:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Theme] Varia [Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants