This repository has been archived by the owner on Feb 17, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 360
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Blockbase: Add comments to Blockbase for the respective Gutenberg iss…
…ues (#4551) * Blockbase: Add comments to Blockbase for the respective Gutenberg issues * update image alignment issue
- Loading branch information
Showing
16 changed files
with
32 additions
and
25 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
// TODO: This can be removed when Gutenberg applies fontFamily correcly to .wp-block-code code (https://github.com/WordPress/gutenberg/issues/31135) | ||
// TODO: This can be removed when Gutenberg applies fontFamily correcly to .wp-block-code code. | ||
.wp-block-code code { | ||
font-family: var(--wp--custom--code--typography--font-family); | ||
font-family: var(--wp--custom--code--typography--font-family); // See https://github.com/WordPress/gutenberg/issues/31135 | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
// TODO: This can be removed when Gutenberg no longer expresses opinion about the bottom margin of the block columns | ||
// or perhaps when the margins of blocks can be styled with the "style" portion of theme.json | ||
// See: https://github.com/WordPress/gutenberg/pull/34630 | ||
.wp-block-columns { | ||
margin-bottom: unset; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
// See https://github.com/WordPress/gutenberg/issues/34645 | ||
.block-library-html__edit { | ||
.block-editor-plain-text { | ||
color: var(--wp--custom--form--color--text); | ||
border: var(--wp--custom--form--border--width) var(--wp--custom--form--border--style) var(--wp--custom--form--border--color); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,11 @@ | ||
.wp-block-image { | ||
/* | ||
/* | ||
From what I can tell the below are styles regularly used by themes | ||
to fix the image block. I believe these should go into the block's | ||
default styles. It's difficult to say how this will land, however | ||
based on discussion found in (many) related issues here: | ||
default styles. It's difficult to say how this will land, however | ||
based on discussion found in (many) related issues here: | ||
https://github.com/WordPress/gutenberg/issues/28923 | ||
https://github.com/WordPress/gutenberg/issues/29506 | ||
*/ | ||
text-align: center; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
.wp-block-latest-posts .wp-block-latest-posts__post-date, | ||
.wp-block-latest-posts .wp-block-latest-posts__post-author { | ||
color: var(--wp--custom--latest-posts--meta--color--text); | ||
} | ||
color: var(--wp--custom--latest-posts--meta--color--text); // See https://github.com/WordPress/gutenberg/issues/34647. | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
.wp-block-post-author__name { | ||
font-weight: var(--wp--custom--post-author--font-weight); | ||
font-weight: var(--wp--custom--post-author--font-weight); // See https://github.com/WordPress/gutenberg/issues/34640 | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
.wp-block-separator { | ||
margin: var(--wp--custom--separator--margin); | ||
opacity: var(--wp--custom--separator--opacity); // Mirror controls that Gutenberg theme.css offers: https://github.com/WordPress/gutenberg/blob/trunk/packages/block-library/src/separator/theme.scss | ||
margin: var(--wp--custom--separator--margin); // See https://github.com/WordPress/gutenberg/pull/30609 is merged | ||
opacity: var(--wp--custom--separator--opacity); // Mirror controls that Gutenberg theme.css offers: https://github.com/WordPress/gutenberg/blob/trunk/packages/block-library/src/separator/theme.scss - See: https://github.com/WordPress/gutenberg/issues/34637 | ||
&:not(.is-style-wide){ | ||
width: var(--wp--custom--separator--width); | ||
width: var(--wp--custom--separator--width); // See https://github.com/WordPress/gutenberg/issues/34638 | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,17 @@ | ||
// See https://github.com/WordPress/gutenberg/issues/31261 | ||
.wp-block-table.is-style-stripes, | ||
.wp-block-table { | ||
figcaption { | ||
figcaption { // See https://github.com/WordPress/gutenberg/issues/34650 | ||
font-size: var(--wp--custom--table--figcaption--typography--font-size); | ||
text-align: center; | ||
} | ||
|
||
td, th { | ||
// See https://github.com/WordPress/gutenberg/issues/31261 | ||
border: 1px solid; | ||
padding: calc(0.5*var(--wp--custom--margin--vertical)) calc(0.5*var(--wp--custom--margin--horizontal)); | ||
} | ||
|
||
margin-bottom: 1em; | ||
margin-bottom: 1em; // See https://github.com/WordPress/gutenberg/issues/34652 | ||
border-bottom: none; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters