PHPCS Fixes #160
Draft
PHPCS Fixes #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trepmal
requested changes
Jul 7, 2021
| * | ||
| * @return string|void | ||
| */ | ||
| function syn_handle_multiple_error_notices( $message, $message_data ) { //phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals |
There was a problem hiding this comment.
Is this ignore necessary? Looks like syn was added as an allowed prefix in .phpcs.xml.dist
There was a problem hiding this comment.
No, I forgot to remove it when I added the prefix to .phpcs.xml.dist. Removed.
| @@ -1,18 +1,72 @@ | |||
| <?php | |||
There was a problem hiding this comment.
changes here discussed in #159
| @@ -492,7 +532,7 @@ public static function display_settings( $site ) { | |||
| <label for="feed_url"><?php esc_html_e( 'Enter feed URL', 'push-syndication' ); ?></label> | |||
| </p> | |||
| <p> | |||
| <input type="text" name="feed_url" id="feed_url" size="100" value="<?php esc_attr_e( $feed_url ); ?>" /> | |||
| <input type="text" name="feed_url" id="feed_url" size="100" value="<?php echo esc_url_raw( $feed_url ); ?>" /> | |||
There was a problem hiding this comment.
I think this should still use esc_attr()
There was a problem hiding this comment.
Ah yes! I changed it back to esc_attr.
|
|
||
| ?> | ||
|
|
||
| <p> | ||
| <label for=site_url><?php echo esc_html__( 'Enter a valid site URL', 'push-syndication' ); ?></label> | ||
| </p> | ||
| <p> | ||
| <input type="text" class="widefat" name="site_url" id="site_url" size="100" value="<?php echo esc_html( $site_url ); ?>" /> | ||
| <input type="text" class="widefat" name="site_url" id="site_url" size="100" value="<?php echo esc_url_raw( $site_url ); ?>" /> |
There was a problem hiding this comment.
I'd have used esc_attr() here.
|
Thanks for the feedback, I have applied your suggestions. I also added the missing PHPCS changes on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial extensive PHPCS clean-up on the codebase. I tried to address all the WordPress standards where possible and ignored the ones that are valid use cases.
I didn't invest much time in the documentation warnings.
This PR is forked from #159, so it includes the OpenSSL implementation for encryption.
I also added a few TODOs along with the code where we should invest some time to improve (mostly missing nonces and class naming).
(WIP,
class-wp-push-syndication-server.phpis still untouched, and I need to pull the changes from #157)