[UI Tests] Examine / address flakiness in History tests.
#1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can test the changes in simplenote-ios from this Pull Request by:
|
pachlava
changed the title
History tests.History tests.
pachlava
commented
Jan 24, 2024
| @@ -38,6 +37,7 @@ class EmailLogin { | |||
| enterPassword(enteredValue: password) | |||
| app.buttons[UID.Button.logIn].tap() | |||
| handleSavePasswordPrompt() | |||
| waitForSpinnerToDisappear() | |||
There was a problem hiding this comment.
Not really a part of the fix, and not necessary, but it does not hurt, and does not occupy much time, since the function waits for the spinner to disappear. So, if the spinner was not there in the first place, it will be completed really fast.
pachlava
changed the title
History tests.History tests.
tiagomar
approved these changes
Jan 25, 2024
|
|
||
| echo "--- 🚦 Report Tests Status" | ||
| if [[ $TESTS_EXIT_STATUS -eq 0 ]]; then | ||
| echo "Unit Tests seems to have passed (exit code 0). All good 👍" | ||
| echo "UI Tests seems to have passed (exit code 0). All good 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Historytests demonstrated flakiness. E.g. here and here. This was not reproducible locally. The fix consists of two parts:xcresultlog file, so that it's actually copied as BK artifact. Without the log, it was not clear what was going wrong on CI.Six subsequent green executions is not a hard proof of the fix success, but this deserves a chance to be tested in action, IMO.
Test
xcresultfile.Review
Only one developer and one designer are required to review these changes, but anyone can perform the review.
Release
These changes do not require release notes.