Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snios minimum os version to iOS 15 #1548

Merged
merged 15 commits into from
Jan 23, 2024

Conversation

charliescheer
Copy link
Contributor

@charliescheer charliescheer commented Jan 11, 2024

Fix

We are going to update the minimum supported version of iOS for Simplenote to iOS 15.

This PR sets those minimums and then fixes all the warnings that cropped up after making those changes.

Test

This changes a bunch of things, so a general app smoke test would be a good idea. Somethings that definitely need to be confirmed:

  • All three Simplenote widgets look right on iOS 17
  • viewing markdown preview still works
  • sharing from other apps to simplenote still works
  • sharing from the notes app Bear using Text Bundle as the export type works

Review

(Required) Add instructions for reviewers. For example:

Only one developer are required to review these changes, but anyone can perform the review.

@charliescheer charliescheer self-assigned this Jan 11, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 11, 2024

You can test the changes in simplenote-ios from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr1548-b64127c-018d23c0-4c45-4da5-a680-75a6b7a9a278 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Base automatically changed from charlie/fix-rake-file to trunk January 17, 2024 21:27
@charliescheer charliescheer force-pushed the charlie/1542/update-snios-minimum-version branch from 3923128 to 551ccf3 Compare January 18, 2024 20:20
@charliescheer charliescheer marked this pull request as ready for review January 18, 2024 20:21
@charliescheer charliescheer added the tooling Related to anything that supports the building & maintaining of the project. label Jan 18, 2024
@charliescheer charliescheer marked this pull request as draft January 18, 2024 21:29
@charliescheer
Copy link
Contributor Author

Converting back to draft cause I realized the @available version checking wasn't removed yet

@charliescheer charliescheer marked this pull request as ready for review January 19, 2024 22:03
@charliescheer
Copy link
Contributor Author

Okay, this is finally ready now

@peril-automattic
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ All test scenarios verified
✅ Changes look beautiful

Nice work sir!!!

:shipit:

@charliescheer charliescheer merged commit 881a4ee into trunk Jan 23, 2024
7 checks passed
@charliescheer charliescheer deleted the charlie/1542/update-snios-minimum-version branch January 23, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Related to anything that supports the building & maintaining of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Xcode project settings Update minimum supported iOS version to iOS 15
3 participants