-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hook to conditionally show the lesson actions block in the frontend #7677
Merged
Imran92
merged 9 commits into
trunk
from
fix/prevent-rendering-lesson-actions-in-content-drip
Oct 30, 2024
Merged
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
7625f33
Add hook to prevent rendering lesson actions
Imran92 fc89550
Add tests to make sure the hook is working
Imran92 010d10f
Add changelog
Imran92 438d8ca
Split a test in two
Imran92 3bb10f6
Merge branch 'trunk' into fix/prevent-rendering-lesson-actions-in-con…
Imran92 2918b2b
Fix test
Imran92 a4de250
Test the version
Imran92 14ec322
Remove test lines
Imran92 1c1e3ee
Merge branch 'trunk' into fix/prevent-rendering-lesson-actions-in-con…
Imran92 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
4 changes: 4 additions & 0 deletions
4
changelog/fix-prevent-rendering-lesson-actions-in-content-drip
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
Significance: minor | ||
Type: development | ||
|
||
Added a hook to conditionally render the lesson actions in the frontend |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test case name is somewhat misleading. In particular, the
WhenHookSetsFalse
part because in this test case we're testing bothtrue
andfalse
. We could split these into 2 separate use cases to test each since there isn't much repetitive setup code.