-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid caching when getting course structure #7654
base: trunk
Are you sure you want to change the base?
Conversation
Test the previous changes of this PR with WordPress Playground. |
041bc28
to
5f7ffb7
Compare
Test the previous changes of this PR with WordPress Playground. |
@merkushin I noticed this one is in Draft but assigned to Nexus. Is it ready for review? |
Hey @merkushin! As per your concern about performance that you mentioned to me, I think it's very important and it would be worth checking where this cache would be skipped to see if it could have a negative impact. That said, I tested it in Pressable and I still see the issue here: Screen.Recording.2024-08-02.at.15.24.10.mov |
@donnapep not yet. It is unfinished yet, especially considering Renatho's reply. I asked Renatho to look at it as he had some experience with addressing a similar issue. |
OK, in that case I'm going to remove Nexus as reviewer so that I don't get notifications in my inbox. Not sure there's a way to disable those. |
Resolves #7146
Proposed Changes
Testing Instructions
Pre-Merge Checklist