Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve status when emails are re-created #6902

Draft
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

donnapep
Copy link
Collaborator

Resolves #6893.

Proposed Changes

  • Preserve the existing status of emails when they are re-created.
  • Also changes "recreate" (incorrect) to "re-create" (correct).

Testing Instructions

  1. Disable some of the emails and enable others.
  2. Re-create the emails from Sensei > Tools.
  3. Check to ensure that the status of every email is preserved.

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Acceptance criteria is met
  • Decisions are publicly documented
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • New UIs match the designs
  • Different user privileges (admin, teacher, subscriber) are tested as appropriate
  • Code is tested on the minimum supported PHP and WordPress versions
  • User interface changes have been tested on the latest versions of Chrome, Firefox and Safari
  • "Needs Documentation" label is added if this change requires updates to documentation
  • Known issues are created as new GitHub issues

@donnapep donnapep changed the title Fix/post status email regeneration Preserve status when emails are re-created May 19, 2023
@merkushin
Copy link
Member

@donnapep is this draft abandoned?

@donnapep
Copy link
Collaborator Author

donnapep commented Jul 3, 2023

@merkushin Nope, I didn't have time to finish it on my janitorial rotation. It would be great if a janitor could pick it up. 🙂 I think it just needs tests maybe?

@donnapep
Copy link
Collaborator Author

Feel free to take over this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preserve status when emails are re-created
2 participants