-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Style Corrections archive templates #2438
base: trunk
Are you sure you want to change the base?
Conversation
@leogermani For the archive page description we can add a Customize setting, but we'll have to address #2435 (comment) before I add a setting for description. |
<?php echo esc_html( get_the_content() ); ?><br/> | ||
<a href="<?php echo esc_url( get_permalink( $related_post_id ) ); ?>"> | ||
<strong class="correction__item-title"> | ||
<?php echo esc_html( $correction_heading ); ?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, the date and time should follow whichever format is set in the site Settings, so the Timezone name there should only be dislpayed if it's set to be displayed in the admin...
I think only working with the_date and _the_time should be fine here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ommitted the timezone from the heading.✅
@thomasguillot can you have a look? |
bc47a48
to
3632d34
Compare
It looks great, thank you @Takshil-Kunadia. One thing that seems to be missing is the ability to control the number of corrections per page. Currently, it follows |
All Submissions:
Changes proposed in this Pull Request:
This pull request introduces styling enhancement to the correction archive templates to match the design shared.
Closes https://app.asana.com/0/1209292256643614/1209292256643623
Demo:-
Screen.Recording.2025-02-17.at.1.16.06.PM.mov
How to test the changes in this Pull Request:
Other information: