Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Style Corrections archive templates #2438

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

Takshil-Kunadia
Copy link
Collaborator

@Takshil-Kunadia Takshil-Kunadia commented Feb 17, 2025

All Submissions:

Changes proposed in this Pull Request:

This pull request introduces styling enhancement to the correction archive templates to match the design shared.

Closes https://app.asana.com/0/1209292256643614/1209292256643623

Demo:-

Screen.Recording.2025-02-17.at.1.16.06.PM.mov

How to test the changes in this Pull Request:

  1. Navigate to the corrections archive page.
  2. Observe the layout and styling to ensure it aligns with the intended design specifications.
  3. Verify that all elements are displayed correctly and that the page is responsive across different devices and screen sizes.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@Takshil-Kunadia
Copy link
Collaborator Author

@leogermani For the archive page description we can add a Customize setting, but we'll have to address #2435 (comment) before I add a setting for description.

@Takshil-Kunadia Takshil-Kunadia changed the title feat: Style Archive templates feat: Style Corrections archive templates Feb 17, 2025
@leogermani leogermani requested a review from a team February 24, 2025 13:58
<?php echo esc_html( get_the_content() ); ?><br/>
<a href="<?php echo esc_url( get_permalink( $related_post_id ) ); ?>">
<strong class="correction__item-title">
<?php echo esc_html( $correction_heading ); ?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, the date and time should follow whichever format is set in the site Settings, so the Timezone name there should only be dislpayed if it's set to be displayed in the admin...

I think only working with the_date and _the_time should be fine here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ommitted the timezone from the heading.✅

@leogermani leogermani marked this pull request as ready for review February 28, 2025 18:42
@leogermani leogermani requested a review from a team as a code owner February 28, 2025 18:42
@leogermani
Copy link
Contributor

@thomasguillot can you have a look?

@Takshil-Kunadia Takshil-Kunadia force-pushed the feature/archive-corrections branch from bc47a48 to 3632d34 Compare March 3, 2025 03:58
@thomasguillot
Copy link
Contributor

It looks great, thank you @Takshil-Kunadia.

One thing that seems to be missing is the ability to control the number of corrections per page. Currently, it follows posts_per_page, which isn’t quite enough for this CPT’s archive page. Would it be possible to make this configurable via wp-config, such as: define( 'NEWSPACK_CORRECTIONS_PER_PAGE', 20 );... What do you think @leogermani?

@thomasguillot thomasguillot removed the request for review from a team March 3, 2025 10:08
@thomasguillot thomasguillot added [Status] Needs Review The issue or pull request needs to be reviewed and removed [Status] Needs Design Review labels Mar 3, 2025
@thomasguillot thomasguillot requested a review from leogermani March 3, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The issue or pull request needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants