Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: workaround for block editor crash #2425

Merged
merged 1 commit into from
Dec 16, 2024
Merged

fix: workaround for block editor crash #2425

merged 1 commit into from
Dec 16, 2024

Conversation

claudiulodro
Copy link
Contributor

@claudiulodro claudiulodro commented Dec 16, 2024 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Workaround fix for an issue publishers have reported. With WC 9.5.0, the block inserter crashes the post editor when opened.

How to test the changes in this Pull Request:

Note: This is a hotfix release.

  1. You can use woo-edit-issue.newspackstaging.com since WC 9.5.0 isn't publicly available yet. This site has just WC 9.5.0 and Newspack Theme active.
  2. Edit a post. Click the + icon in the top left corner to open the block inserter. Observe the editor crashes with an error in the console about the post-title block.
  3. Apply this patch. Edit a post. Click the + icon, etc. Observe the editor does not crash.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@claudiulodro claudiulodro added the [Status] Needs Review The issue or pull request needs to be reviewed label Dec 16, 2024
@claudiulodro claudiulodro requested a review from a team as a code owner December 16, 2024 16:54
miguelpeixe
miguelpeixe approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@miguelpeixe miguelpeixe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to change the base to release before merging.

@dkoo
Copy link
Contributor

dkoo commented Dec 16, 2024

Note: This is a hotfix release.

@claudiulodro can you rebase against release, please?

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Dec 16, 2024
@claudiulodro claudiulodro changed the base branch from trunk to release December 16, 2024 16:59
@claudiulodro
Copy link
Contributor Author

Ah right, always forget that step 🤦‍♂️

dkoo
dkoo approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the bug and the fix! 👍

@claudiulodro claudiulodro merged commit dfc25b1 into release Dec 16, 2024
6 checks passed
@claudiulodro claudiulodro deleted the fix/woo-block branch December 16, 2024 17:14
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelpeixe miguelpeixe miguelpeixe approved these changes

@dkoo dkoo dkoo approved these changes

Assignees
No one assigned
Labels
released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@claudiulodro @dkoo @matticbot @miguelpeixe