Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update template for woo 8.7.0 #2264

Merged
merged 2 commits into from
Mar 27, 2024
Merged

fix: update template for woo 8.7.0 #2264

merged 2 commits into from
Mar 27, 2024

Conversation

laurelfulford
Copy link
Contributor

@laurelfulford laurelfulford commented Mar 21, 2024 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Replaces #2263; I switched it to a hotfix since these alerts can cause worries for publishers/lot of communication for support.

This PR gets the order-details-customer.php file in the Newspack theme up-to-date with what was changed in the template in the WooCommerce 8.7.0 release, to prevent a message from displaying.

See 1200550061930446-as-1206883834710822

How to test the changes in this Pull Request:

  1. Make sure WooCommerce is up-to-date on your test site.
  2. View the WP Admin; note you have a notice like this:

image

  1. Apply this PR.
  2. Confirm that the notice goes away.
  3. Navigate to /my-account > Orders, and confirm there are no issues.
  4. Spot-check the file's changes against the ones made in the WooCommerce plugin here, to make sure they line up.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford requested a review from a team as a code owner March 21, 2024 15:31
@laurelfulford laurelfulford added the [Status] Needs Review The issue or pull request needs to be reviewed label Mar 21, 2024
dkoo
dkoo approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described!

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Mar 22, 2024
@laurelfulford laurelfulford merged commit 7be65dc into release Mar 27, 2024
3 checks passed
@laurelfulford laurelfulford deleted the hotfix/update-templates-woo-8.7.0 branch March 27, 2024 16:08
matticbot pushed a commit that referenced this pull request Mar 27, 2024
@semantic-release-bot
chore(release): 1.87.1 [skip ci]
cffb8c0 
## [1.87.1](v1.87.0...v1.87.1) (2024-03-27)

### Bug Fixes

* update template for woo 8.7.0 ([#2264](#2264)) ([7be65dc](7be65dc))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.87.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkoo dkoo dkoo approved these changes

Assignees
No one assigned
Labels
released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laurelfulford @matticbot @dkoo