Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add large image size for larger featured images #2254

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Our theme uses 1200px for featured images, but this isn't really adequate for the large featured image sizes that came after the theme was first built -- specifically, the Behind, Above and sometimes Behind (due to height) image sizes.

This PR adds an additional 2000px size to just use for those cases on single posts and pages. It does mean larger image sizes, but Jetpack's Site Accelerator should help balance that out.

See 1200550061930446-as-1205443589299352

How to test the changes in this Pull Request:

  1. Create three posts with the above, behind and beside featured image placements, respectively.
  2. Publish, and view on the front-end; note that the image quality isn't great, especially on larger screens.
  3. Apply the PR; you will likely also need to regenerate thumbnails just to get your images up to date; you can use this plugin or the CLI command.
  4. Refresh your posts and confirm they're loading a larger image size. Note: it still may not be ideal for all images -- like ones that are more illustrative/text heavy -- but it should be an improvement!

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford added the [Status] Needs Review The issue or pull request needs to be reviewed label Feb 28, 2024
@laurelfulford laurelfulford requested a review from a team as a code owner February 28, 2024 18:59
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Mar 1, 2024
@laurelfulford
Copy link
Contributor Author

Thanks @adekbadek!

@laurelfulford laurelfulford merged commit 86be097 into trunk Mar 5, 2024
4 checks passed
@laurelfulford laurelfulford deleted the feat/increase-feat-image-size branch March 5, 2024 22:47
matticbot pushed a commit that referenced this pull request Mar 7, 2024
# [1.87.0-alpha.1](v1.86.0...v1.87.0-alpha.1) (2024-03-07)

### Features

* add large image size for larger featured images ([#2254](#2254)) ([86be097](86be097))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.87.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Mar 25, 2024
# [1.87.0](v1.86.0...v1.87.0) (2024-03-25)

### Features

* add large image size for larger featured images ([#2254](#2254)) ([86be097](86be097))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.87.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants