Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: usage of filter for post author footer bio name #1966

Merged
merged 1 commit into from
Nov 3, 2022
Merged

fix: usage of filter for post author footer bio name #1966

merged 1 commit into from
Nov 3, 2022

Conversation

adekbadek
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

The newspack_author_bio_name filter was added in #1806, then its use was partially removed in #1848. This change introduces a different approach to the issue (partially) solved in #1848, and re-enables the newspack_author_bio_name filter.

How to test the changes in this Pull Request:

  1. Re-test fix: correct issue with duplicated Trust Indicator role in author bio #1848
  2. See instructions in Feat/author fields newspack-plugin#2102

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek
fix: usage of filter for post author footer bio name
4cedf9b 
The filter was added in #1806, then its use was partially removed in #1848. This change introduces a different approach to the issue (partially) solved in #1848, and re-enables the newspack_author_bio_name filter.
@adekbadek adekbadek added the [Status] Needs Review The issue or pull request needs to be reviewed label Nov 1, 2022
@adekbadek adekbadek requested a review from a team as a code owner November 1, 2022 12:01
@adekbadek adekbadek mentioned this pull request Nov 3, 2022
Merged
6 tasks
leogermani
leogermani approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@leogermani leogermani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well

@adekbadek adekbadek merged commit 8aa871b into master Nov 3, 2022
@adekbadek adekbadek deleted the feat/author-custom-fields branch November 3, 2022 16:36
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.65.2-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.65.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogermani leogermani leogermani approved these changes

Assignees
No one assigned
Labels
released on @alpha released [Status] Needs Review The issue or pull request needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adekbadek @matticbot @leogermani