Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use guest authors in Slack preview when needed #947

Merged
merged 1 commit into from
May 3, 2021
Merged

Use guest authors in Slack preview when needed #947

merged 1 commit into from
May 3, 2021

Conversation

claudiulodro
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Closes #946

This PR integrates with Yoast to display the guest author in the twitter:data1 tag which Slack uses in its previews. For the second part of #946 (Integrating CAP with Yoast schema data), there's an open issue at the CAP repo, so it should be handled in CAP at some point (hopefully soon now that Yoast is adding a filter in the next release for modifying the data).

How to test the changes in this Pull Request:

  1. Before applying this patch, add a guest author to a post and view the page source. In the <meta name="twitter:data1" content="AUTHORNAME"> tag, you should see the name of the "real" post author, not the guest author.
  2. Apply this patch. Refresh the page. In the <meta name="twitter:data1" content="GUESTAUTHORNAME"> you should see the name of the guest author.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@claudiulodro claudiulodro added the [Status] Needs Review The issue or pull request needs to be reviewed label Apr 30, 2021
@dkoo dkoo requested review from dkoo and adekbadek May 3, 2021 16:11
dkoo
dkoo approved these changes May 3, 2021
View reviewed changes
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described with the twitter:data1 tag and the Slack preview (correctly shows the guest author instead of the "real" user). Still seeing the "real" user in the twitter:creator tag and in all Schema data—assuming that's the part that needs to get fixed in CAP, correct?

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels May 3, 2021
@claudiulodro
Copy link
Contributor Author

Still seeing the "real" user in the twitter:creator tag and in all Schema data—assuming that's the part that needs to get fixed in CAP, correct?

Yeah that should be handled with the (eventual) upcoming CAP integration. Thanks for the review!

@claudiulodro claudiulodro merged commit e42680e into master May 3, 2021
@claudiulodro claudiulodro deleted the fix/cap-authors branch May 3, 2021 17:56
matticbot pushed a commit that referenced this pull request May 4, 2021
@semantic-release-bot
chore(release): 1.38.0-alpha.1 [skip ci]
c088ab0 
# [1.38.0-alpha.1](v1.37.0...v1.38.0-alpha.1) (2021-05-04)

### Bug Fixes

* use guest authors in Slack preview when needed ([#947](#947)) ([e42680e](e42680e))

### Features

* batch amp-analytics events ([481dc97](481dc97)), closes [#914](#914)
* integrate Newspack Scheduled Post Checker into main plugin ([#940](#940)) ([c6adc1b](c6adc1b))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.38.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request May 4, 2021
@semantic-release-bot
chore(release): 1.38.0 [skip ci]
c4fe724 
# [1.38.0](v1.37.0...v1.38.0) (2021-05-04)

### Bug Fixes

* use guest authors in Slack preview when needed ([#947](#947)) ([e42680e](e42680e))

### Features

* batch amp-analytics events ([481dc97](481dc97)), closes [#914](#914)
* integrate Newspack Scheduled Post Checker into main plugin ([#940](#940)) ([c6adc1b](c6adc1b))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.38.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@tmmbecker tmmbecker mentioned this pull request May 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkoo dkoo dkoo approved these changes

@adekbadek adekbadek Awaiting requested review from adekbadek

Assignees
No one assigned
Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shares incorrectly display guest author details
3 participants
@claudiulodro @matticbot @dkoo