Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(my-account): sync email change with stripe #3789

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

chickenn00dle
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Closes https://app.asana.com/0/1208993180326452/1209215513701723

This PR ensures a customers email address is updated in Stripe when changed via my account:

Screenshot 2025-02-28 at 15 54 15

How to test the changes in this Pull Request:

  1. Find any reader in your stripe dashboard
  2. Log in as the reader and go to my account
  3. Update your email address and save details
  4. Verify via the sent email
  5. Once redirected to my account, check the stripe dashboard and confirm the email address has updated there as well
  6. Repeat steps 1-4 with a reader account that is not associated with stripe
  7. Verify you don't run into any errors or issues

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@chickenn00dle chickenn00dle requested a review from a team as a code owner February 28, 2025 21:02
@chickenn00dle chickenn00dle force-pushed the feat/stripe-sync-email-change branch from d40eb08 to 821c4cf Compare February 28, 2025 21:03
@chickenn00dle chickenn00dle added the [Status] Needs Review The issue or pull request needs to be reviewed label Feb 28, 2025
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Feb 28, 2025
@chickenn00dle chickenn00dle merged commit 4f45795 into trunk Mar 3, 2025
9 checks passed
@chickenn00dle chickenn00dle deleted the feat/stripe-sync-email-change branch March 3, 2025 15:10
Copy link

github-actions bot commented Mar 3, 2025

Hey @chickenn00dle, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants