Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(correction-blocks): Correction box & Loop item + Template #3787

Open
wants to merge 7 commits into
base: trunk
Choose a base branch
from

Conversation

Takshil-Kunadia
Copy link
Collaborator

All Submissions:

Changes proposed in this Pull Request:

Closes https://app.asana.com/0/1209292256643614/1209292256643625

How to test the changes in this Pull Request:

Testing Corrections Box Block:-

  1. Create a post add corrections/clarifications.
  2. Add Corrections box block to see the corrections.
  3. Save the post and view the corrections on the front-end.
  4. Modify the corrections on the editor/Add new corrections and click on refresh button to view updated corrections.

Testing Corrections Loop Block Pattern:-

  1. Create a new Page and click + > Patterns Corrections Loop.
  2. Edit the template to change the title/description.
  3. Save & view the page on front-end.

Testing Corrections Archive Block Template:-

  1. Go to Site editor > Template > Search "Corrections" > "Corrections Archive".
  2. Edit the template to replace Header & Footer / change the title/description.
  3. Create a new Page and Select Corrections Archive template.
  4. Save & view the page on front-end.

For individual testing of the Corrections Loop item block

  1. Add a Query Loop block and add Post Template and Pagination blocks inside it.
  2. In Post Template block, Add correction Item block.
  3. Set Post type as Corrections in Query Loop block settings. Per page count can also be set here.
  4. View the corrections archive.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@Takshil-Kunadia Takshil-Kunadia force-pushed the feature/correction-blocks branch from a72c96a to 45ff164 Compare February 28, 2025 08:09
@Takshil-Kunadia Takshil-Kunadia marked this pull request as ready for review February 28, 2025 10:52
@Takshil-Kunadia Takshil-Kunadia requested a review from a team as a code owner February 28, 2025 10:53
@github-actions github-actions bot added the [Status] Approved The pull request has been reviewed and is ready to merge label Feb 28, 2025
Copy link
Contributor

@thomasguillot thomasguillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s working well! Just a couple of changes:

  • The timezone isn’t needed
  • The template and pattern strings should be translatable
  • This should be restricted to Block Themes only

@thomasguillot thomasguillot added [Status] Needs Review The issue or pull request needs to be reviewed and removed [Status] Approved The pull request has been reviewed and is ready to merge labels Mar 3, 2025
@thomasguillot thomasguillot requested a review from leogermani March 3, 2025 10:25
@Takshil-Kunadia
Copy link
Collaborator Author

Thanks! @leogermani @thomasguillot for taking a look 🙇 .

The timezone isn’t needed

Removed the timezone from heading ✅

The template and pattern strings should be translatable

Wrapped strings in gettext fns. ✅

This should be restricted to Block Themes only

Assuming this is in reference to the Pattern & Template, yes they will only be registered on block themes.

public static function register_corrections_block_patterns() {
if ( ! class_exists( 'WP_Block_Patterns_Registry' ) || ! wp_is_block_theme() ) {
return;

public static function register_corrections_template() {
if ( ! class_exists( 'WP_Block_Templates_Registry' ) || ! wp_is_block_theme() ) {
return;

@thomasguillot
Copy link
Contributor

Assuming this is in reference to the Pattern & Template, yes they will only be registered on block themes.

Sorry, I was talking about the Blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The issue or pull request needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants