-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(correction-blocks): Correction box & Loop item + Template #3787
base: trunk
Are you sure you want to change the base?
Conversation
a72c96a
to
45ff164
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s working well! Just a couple of changes:
- The timezone isn’t needed
- The template and pattern strings should be translatable
- This should be restricted to Block Themes only
Thanks! @leogermani @thomasguillot for taking a look 🙇 .
Removed the timezone from heading ✅
Wrapped strings in gettext fns. ✅
Assuming this is in reference to the Pattern & Template, yes they will only be registered on block themes. newspack-plugin/includes/corrections/class-corrections.php Lines 554 to 556 in 45ff164
newspack-plugin/includes/corrections/class-corrections.php Lines 597 to 599 in 45ff164
|
Sorry, I was talking about the Blocks. |
All Submissions:
Changes proposed in this Pull Request:
Closes https://app.asana.com/0/1209292256643614/1209292256643625
How to test the changes in this Pull Request:
Testing Corrections Box Block:-
Testing Corrections Loop Block Pattern:-
Corrections Loop
.Testing Corrections Archive Block Template:-
For individual testing of the Corrections Loop item block
Other information: