Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(woo): page template meta leaking to other types #3782

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

miguelpeixe
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

#3781 as a hotfix

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@miguelpeixe miguelpeixe added the [Status] Needs Review The issue or pull request needs to be reviewed label Feb 25, 2025
@miguelpeixe miguelpeixe self-assigned this Feb 25, 2025
@miguelpeixe miguelpeixe requested a review from a team as a code owner February 25, 2025 16:34
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand why, but it works! With apologies to the Woo Memberships plugin, looks like this one was coming from our stuff after all!

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Feb 25, 2025
@miguelpeixe miguelpeixe merged commit 325a21c into release Feb 25, 2025
10 checks passed
@miguelpeixe miguelpeixe deleted the hotfix/woo-template-post-meta-leak branch February 25, 2025 16:37
matticbot pushed a commit that referenced this pull request Feb 25, 2025
## [5.14.4](v5.14.3...v5.14.4) (2025-02-25)

### Bug Fixes

* **woo:** page template meta leaking to other types ([#3782](#3782)) ([325a21c](325a21c))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 5.14.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Feb 27, 2025
# [6.0.0-alpha.2](v6.0.0-alpha.1...v6.0.0-alpha.2) (2025-02-27)

### Bug Fixes

* **memberships:** ensure user membership is linked to the correct subscription ([#3768](#3768)) ([a942616](a942616))
* undo forcing WC order attribution to off ([#3771](#3771)) ([c9cb52a](c9cb52a))
* **woo:** page template meta leaking to other types ([#3782](#3782)) ([325a21c](325a21c))

### Features

* add corrections customize settings ([#3751](#3751)) ([11dbc5e](11dbc5e))
* **corrections:** Unit tests for Corrections functionality ([#3776](#3776)) ([ae58933](ae58933))
* **my-account:** add change email template ([#3772](#3772)) ([32bef3c](32bef3c))
* **my-account:** add pending email change state ([#3763](#3763)) ([c9ba046](c9ba046))
* **my-account:** verify email change ([#3764](#3764)) ([b50c980](b50c980))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 6.0.0-alpha.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants