Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(memberships): reset end date on subscription #3769

Closed

Conversation

miguelpeixe
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

An alternative approach for #3768 and #3393.

There's a known bug that Woo Memberships doesn't reset a membership's "end date" if a subscription reactivates it. On a cron routine, the end date value will get picked up and expire the membership.

This approach hooks into a subscription status update to manually reset the end date of a membership attached to it.

How to test the changes in this Pull Request:

Same steps from #3768

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@miguelpeixe miguelpeixe added the [Status] Needs Review The issue or pull request needs to be reviewed label Feb 21, 2025
@miguelpeixe miguelpeixe self-assigned this Feb 21, 2025
@miguelpeixe miguelpeixe requested a review from a team as a code owner February 21, 2025 14:32
@miguelpeixe
Copy link
Member Author

Superseded by #3768

@miguelpeixe miguelpeixe deleted the hotfix/memberships-end-date-on-subscription branch February 21, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The issue or pull request needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant