fix(esp-sync): broken CLI sync command

[dkoo]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

There must have been a bad merge recently which broke the wp newspack esp sync CLI command.

How to test the changes in this Pull Request:

1. On release, run wp newspack esp sync via CLI and observe an error:

Warning: Undefined variable $customer in /wordpress/plugins/newspack-plugin/5.14.0/includes/reader-activation/sync/class-esp-sync.php on line 241
Fatal error: Uncaught Error: Call to a member function get_email() on null in /wordpress/plugins/newspack-plugin/5.14.0/includes/reader-activation/sync/class-esp-sync.php:241
Stack trace:
#0 /wordpress/plugins/newspack-plugin/5.14.0/includes/cli/class-ras-esp-sync.php(223): Newspack\Reader_Activation\ESP_Sync::sync_contact('10612', true)
#1 /wordpress/plugins/newspack-plugin/5.14.0/includes/cli/class-ras-esp-sync.php(394): Newspack\CLI\RAS_ESP_Sync::sync_contacts(Array)
#2 [internal function]: Newspack\CLI\RAS_ESP_Sync::cli_sync_contacts(Array, Array)
#3 phar:///usr/local/bin/wp-cli/vendor/wp-cli/wp-cli/php/WP_CLI/Dispatcher/CommandFactory.php(100): call_user_func(Array, Array, Array)
#4 [internal function]: WP_CLI\Dispatcher\CommandFactory::WP_CLI\Dispatcher\{closure}(Array, Array)
#5 phar:///usr/local/bin/wp-cli/vendor/wp-cli/wp-cli/php/WP_CLI/Dispatcher/Subcommand.php(497): call_user_func(Object(Closure), Array, Array)
#6 phar:///usr/local/bin/wp-cli/vendor/wp-cli/wp-cli/php/WP_CLI/Runner.php(441): WP_CLI\Dispatcher\Subcommand->invoke(Array, Array, Array)
#7 phar:///usr/local/bin/wp-cli/vendor/wp-cli/wp-cli/php/WP_CLI/Runner.php(464): WP_CLI\Runner->run_command(Array, Array)
#8 phar:///usr/local/bin/wp-cli/vendor/wp-cli/wp-cli/php/WP_CLI/Runner.php(1295): WP_CLI\Runner->run_command_and_exit()
#9 phar:///usr/local/bin/wp-cli/vendor/wp-cli/wp-cli/php/WP_CLI/Bootstrap/LaunchRunner.php(28): WP_CLI\Runner->start()
#10 phar:///usr/local/bin/wp-cli/vendor/wp-cli/wp-cli/php/bootstrap.php(83): WP_CLI\Bootstrap\LaunchRunner->process(Object(WP_CLI\Bootstrap\BootstrapState))
#11 phar:///usr/local/bin/wp-cli/vendor/wp-cli/wp-cli/php/wp-cli.php(32): WP_CLI\bootstrap()
#12 phar:///usr/local/bin/wp-cli/php/boot-phar.php(20): include('phar:///usr/loc...')
#13 /usr/local/bin/wp-cli(4): include('phar:///usr/loc...')
#14 {main}
  thrown in /wordpress/plugins/newspack-plugin/5.14.0/includes/reader-activation/sync/class-esp-sync.php on line 241
Error: There has been a critical error on this website.Learn more about troubleshooting WordPress. There has been a critical error on this website.

2. Check out this branch, re-run, and confirm that it succeeds.

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[miguelpeixe]

The issue was caused by the sync_contact() method decoupling from #3661. It missed updating this variable in the CLI context.

I think the processed count should work either way, given it's static from an inherited class. Still, your change is better.

[matticbot]

🎉 This PR is included in version 5.14.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀