Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ia): newsletters component for the setup wizard #3749

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

miguelpeixe
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

1205919985867982-as-1209354311969241

Fixes the Newsletters settings component import for the setup wizard.

How to test the changes in this Pull Request:

  1. While on the epic/ia branch, navigate to the /wp-admin/admin.php?page=newspack-setup-wizard#/services page
  2. Toggle "Newsletters" on and confirm the fatal js error
  3. Checkout this branch and refresh the page
  4. Toggle "Newsletters" on and confirm you are able to configure and continue

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@miguelpeixe miguelpeixe added [Status] Needs Review The issue or pull request needs to be reviewed Information Architecture labels Feb 13, 2025
@miguelpeixe miguelpeixe self-assigned this Feb 13, 2025
@miguelpeixe miguelpeixe requested a review from a team as a code owner February 13, 2025 13:36
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Feb 14, 2025
@miguelpeixe miguelpeixe merged commit e7025a0 into epic/ia Feb 14, 2025
10 checks passed
@miguelpeixe miguelpeixe deleted the fix/ia-setup-wizard-newsletters-import branch February 18, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Information Architecture [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants