-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/change nicename UI #3740
Feat/change nicename UI #3740
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works! Since this is experimental we probably don't need to request a design review at this point. ESLint is throwing some code style errors which I think can be fixed with the below suggestions.
Co-authored-by: Derrick Koo <[email protected]>
Co-authored-by: Derrick Koo <[email protected]>
Thanks @dkoo ! |
Hey @leogermani, good job getting this PR merged! 🎉 Now, the Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label. If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label. Thank you! ❤️ |
* feat: handle user nicename change * feat: check username availability on CLI * docs: improve doc block * feat: add experimental UI to change nicename * Update src/nicename-change/index.js Co-authored-by: Derrick Koo <[email protected]> * Update src/nicename-change/index.js Co-authored-by: Derrick Koo <[email protected]> --------- Co-authored-by: Derrick Koo <[email protected]>
🎉 This PR is included in version 6.0.0-alpha.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
* feat: handle user nicename change (#3725) * feat: handle user nicename change * feat: check username availability on CLI * docs: improve doc block * Feat/change nicename UI (#3740) * feat: handle user nicename change * feat: check username availability on CLI * docs: improve doc block * feat: add experimental UI to change nicename * Update src/nicename-change/index.js Co-authored-by: Derrick Koo <[email protected]> * Update src/nicename-change/index.js Co-authored-by: Derrick Koo <[email protected]> --------- Co-authored-by: Derrick Koo <[email protected]> --------- Co-authored-by: Derrick Koo <[email protected]>
All Submissions:
Changes proposed in this Pull Request:
This is an experimental UI to #3725.
This is not meant to be enabled for every user, but it can be enabled if there's a special need for this feature.
How to test the changes in this Pull Request:
define( 'NEWSPACK_CHANGE_NICENAME_UI', true );
Other information: