Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/change nicename UI #3740

Merged
merged 7 commits into from
Feb 27, 2025
Merged

Feat/change nicename UI #3740

merged 7 commits into from
Feb 27, 2025

Conversation

leogermani
Copy link
Contributor

@leogermani leogermani commented Feb 10, 2025

All Submissions:

Changes proposed in this Pull Request:

This is an experimental UI to #3725.

This is not meant to be enabled for every user, but it can be enabled if there's a special need for this feature.

How to test the changes in this Pull Request:

  1. add define( 'NEWSPACK_CHANGE_NICENAME_UI', true );
  2. Edit a user
  3. Confirm there's a new section called "Change User archive URL"
  4. Check test instructions on feat: handle user nicename change #3725 and perform them, but using the UI this time

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@leogermani leogermani added the [Status] Needs Review The issue or pull request needs to be reviewed label Feb 10, 2025
@leogermani leogermani self-assigned this Feb 10, 2025
@leogermani leogermani requested a review from a team as a code owner February 10, 2025 21:47
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works! Since this is experimental we probably don't need to request a design review at this point. ESLint is throwing some code style errors which I think can be fixed with the below suggestions.

@leogermani
Copy link
Contributor Author

Thanks @dkoo !

@leogermani leogermani merged commit 6b9aad4 into trunk Feb 27, 2025
7 checks passed
@leogermani leogermani deleted the feat/change-nicename-ui branch February 27, 2025 12:36
Copy link

Hey @leogermani, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

leogermani added a commit that referenced this pull request Feb 27, 2025
* feat: handle user nicename change

* feat: check username availability on CLI

* docs: improve doc block

* feat: add experimental UI to change nicename

* Update src/nicename-change/index.js

Co-authored-by: Derrick Koo <[email protected]>

* Update src/nicename-change/index.js

Co-authored-by: Derrick Koo <[email protected]>

---------

Co-authored-by: Derrick Koo <[email protected]>
@matticbot
Copy link
Contributor

🎉 This PR is included in version 6.0.0-alpha.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

naxoc pushed a commit that referenced this pull request Feb 27, 2025
* feat: handle user nicename change (#3725)

* feat: handle user nicename change

* feat: check username availability on CLI

* docs: improve doc block

* Feat/change nicename UI (#3740)

* feat: handle user nicename change

* feat: check username availability on CLI

* docs: improve doc block

* feat: add experimental UI to change nicename

* Update src/nicename-change/index.js

Co-authored-by: Derrick Koo <[email protected]>

* Update src/nicename-change/index.js

Co-authored-by: Derrick Koo <[email protected]>

---------

Co-authored-by: Derrick Koo <[email protected]>

---------

Co-authored-by: Derrick Koo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @alpha [Status] Needs Review The issue or pull request needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants