Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(recaptcha): remove v3 from heading; preserve settings on toggle #3739

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Feb 10, 2025

All Submissions:

Changes proposed in this Pull Request:

Fixes the heading for reCAPTCHA in Newspack > Settings, and fixes a small bug when toggling on or off.

How to test the changes in this Pull Request:

  1. On epic/ia, visit Newspack > Settings.
  2. Observe that the reCAPTCHA settings heading says reCAPTCHA v3.
  3. Toggle on reCAPTCHA, select v2, enter some credentials, and save.
  4. Toggle off reCAPTCHA, then toggle on again, and observe that the settings you saved in step 3 have been lost.
  5. Check out this branch and refresh.
  6. Confirm that the heading now says just reCAPTCHA.
  7. Repeat steps 3-4 and confirm that after toggling reCAPTCHA on again, your previously saved settings are restored.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo added [Status] Needs Review The issue or pull request needs to be reviewed Information Architecture labels Feb 10, 2025
@dkoo dkoo self-assigned this Feb 10, 2025
@dkoo dkoo requested a review from a team as a code owner February 10, 2025 21:21
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Feb 11, 2025
@dkoo dkoo merged commit 470f385 into epic/ia Feb 12, 2025
10 checks passed
@dkoo dkoo deleted the fix/recaptcha-ui branch February 12, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Information Architecture [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants