Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wcs): update subscriptions expiration cli behavior #3617

Merged
merged 5 commits into from
Dec 12, 2024
Merged

fix(wcs): update subscriptions expiration cli behavior #3617

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d016ca4
fix: schedule final retry
chickenn00dle Dec 11, 2024
5ad0e30
fix: account for manual subscriptions
chickenn00dle Dec 11, 2024
3e9e2d4
fix: check for manual subscriptions earlier
chickenn00dle Dec 12, 2024
483a600
fix: add retry meta and note
chickenn00dle Dec 12, 2024
5c28527
fix: add subscription update meta
chickenn00dle Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 48 additions & 8 deletions includes/cli/class-woocommerce-subscriptions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

use WP_CLI;
use Newspack\Woocommerce_Subscriptions as WooCommerce_Subscriptions_Integration;
use Newspack\On_Hold_Duration;

defined( 'ABSPATH' ) || exit;

Expand Down Expand Up @@ -66,6 +67,7 @@ public function migrate_expired_subscriptions( $args, $assoc_args ) {
self::$ids = isset( $assoc_args['ids'] ) ? explode( ',', $assoc_args['ids'] ) : false;
self::$live = isset( $assoc_args['live'] ) ? true : false;
self::$verbose = isset( $assoc_args['verbose'] ) ? true : false;
$scheduled = 0;
$updated = 0;
$page = 1;
$per_page = 25;
Expand Down Expand Up @@ -126,15 +128,53 @@ public function migrate_expired_subscriptions( $args, $assoc_args ) {
}
continue;
} else {
if ( self::$verbose ) {
WP_CLI::line( 'Updating subscription status to expired...' );
if ( $subscription->is_manual() || ! $subscription->payment_method_supports( 'subscription_date_changes' ) ) {
if ( self::$verbose ) {
WP_CLI::line( 'Subscription does not support retries. Moving to next subscription...' );
WP_CLI::line( '' );
}
continue;
}
if ( self::$live ) {
$subscription->update_status( 'expired', __( 'Subscription status updated by Newspack CLI command.', 'newspack-plugin' ) );
$subscription->set_end_date( $last_retry->get_date() );
$subscription->save();
$retry_date = $last_retry->get_date();
$on_hold_duration = On_Hold_Duration::get_on_hold_duration();
// If the retry date is within the on-hold duration, schedule a final retry.
if ( wcs_date_to_time( $retry_date ) + ( $on_hold_duration * DAY_IN_SECONDS ) > time() ) {
if ( self::$verbose ) {
WP_CLI::line( 'Retry date is within the on-hold duration. Scheduling final retry...' );
}
if ( self::$live ) {
// Retry rules can only be applied when payment attempt flag is set.
add_filter( 'wcs_is_scheduled_payment_attempt', '__return_true' );
\WCS_Retry_Manager::maybe_apply_retry_rule( $subscription, $renewal_order );
remove_filter( 'wcs_is_scheduled_payment_attempt', '__return_true' );
if ( 0 === $subscription->get_date( 'payment_retry' ) ) {
if ( self::$verbose ) {
WP_CLI::error( 'Failed to schedule payment retry. Moving to next subscription...' );
WP_CLI::line( '' );
}
continue;
} else {
$subscription->add_order_note(
__( 'Final payment retry scheduled by Newspack CLI command.', 'newspack-plugin' )
);
$subscription->update_meta_data( '_newspack_cli_retry_scheduled', true );
$subscription->save();
}
}
++$scheduled;
} else {
// Otherwise, if the retry date is past the on-hold duration, update the subscription status to expired.
if ( self::$verbose ) {
WP_CLI::line( 'Updating subscription status to expired...' );
}
if ( self::$live ) {
$subscription->update_status( 'expired', __( 'Subscription status updated by Newspack CLI command.', 'newspack-plugin' ) );
$subscription->set_end_date( $retry_date );
$subscription->update_meta_data( '_newspack_cli_status_updated', true );
$subscription->save();
}
++$updated;
}
++$updated;
}
if ( self::$verbose ) {
WP_CLI::line( 'Finished processing subscription ' . $id );
Expand All @@ -143,7 +183,7 @@ public function migrate_expired_subscriptions( $args, $assoc_args ) {
}
$subscriptions = self::get_subscriptions( ++$page );
}
WP_CLI::success( 'Finished processing subscriptions. ' . $updated . ' subscriptions updated.' );
WP_CLI::success( 'Finished processing subscriptions. ' . $updated . ' subscriptions updated. ' . $scheduled . ' retries scheduled.' );
if ( ! self::$live ) {
WP_CLI::warning( 'Dry run. Use --live flag to process live subscriptions.' );
}
Expand Down
Loading