Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): check theme mod key #3519

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

miguelpeixe
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

1205919985867982-as-1208686181349205/f

Checks the key to prevent a backend warning and a javascript fatal.

How to test the changes in this Pull Request:

  1. While on the epic branch, delete the theme_mods_newspack-theme option from the db
  2. Navigate to Newspack -> Dashboard and confirm the page renders blank with a js error
  3. Checkout this branch, refresh the page and confirm the dashboard renders without errors

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@miguelpeixe miguelpeixe added the [Status] Needs Review The issue or pull request needs to be reviewed label Nov 4, 2024
@miguelpeixe miguelpeixe self-assigned this Nov 4, 2024
@miguelpeixe miguelpeixe requested a review from a team as a code owner November 4, 2024 20:32
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Nov 4, 2024
@miguelpeixe miguelpeixe merged commit 1609d52 into epic/ia Nov 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants