fix(wp-6.7): use wordpress radio control component #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this one in favor of Automattic/newspack-plugin#3518 where we update our radio control component to work with 6.7 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newspack-components radio control used in the multibranded site wizard seems to be conflicting with the styles from WP 6.7's radio control component. As a result, the radio inputs appear warped:
This PR addresses this issue by just using the default WP radio control component here instead:
Testing Instructions
Note that right now multibranded site wizard is broken as a result of this change #56. To test this, you will need to revert these changes locally until that PR is either reverted or fixed in some other way.