Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal-checkout): treat express checkouts as modal checkouts #1654

Merged
merged 3 commits into from
Jan 31, 2024
Merged

fix(modal-checkout): treat express checkouts as modal checkouts #1654

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f9350a
fix(modal-checkout): treat express checkouts as modal checkouts
dkoo Jan 26, 2024
712858a
fix: check if modal checkout during express checkout requests
dkoo Jan 30, 2024
2757936
feat: validate payment_request_type values
dkoo Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions includes/class-modal-checkout.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -965,6 +965,11 @@ public static function is_modal_checkout() {
if ( ! $is_modal_checkout && isset( $_REQUEST['post_data'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Recommended
$is_modal_checkout = strpos( $_REQUEST['post_data'], 'modal_checkout=1' ) !== false; // phpcs:ignore WordPress.Security.NonceVerification.Recommended, WordPress.Security.ValidatedSanitizedInput.MissingUnslash, WordPress.Security.ValidatedSanitizedInput.InputNotSanitized
}

// Express checkout payments won't have the modal checkout flag even if triggered from the modal, so let's treat those as modal checkouts.
if ( ! $is_modal_checkout && ! empty( filter_input( INPUT_POST, 'payment_request_type', FILTER_SANITIZE_FULL_SPECIAL_CHARS ) ) ) {
$is_modal_checkout = true;
}
return $is_modal_checkout;
}

Expand Down