Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal-checkout): show order details table with fees #1633

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

miguelpeixe
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Show order details table on the modal checkout if the cart contains fees.

How to test the changes in this Pull Request:

Instructions at Automattic/newspack-plugin#2820

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@miguelpeixe miguelpeixe merged commit 07c0642 into master Dec 22, 2023
@miguelpeixe miguelpeixe deleted the fix/modal-checkout-review-table-fee branch December 22, 2023 18:45
matticbot pushed a commit that referenced this pull request Dec 22, 2023
# [2.5.0-alpha.2](v2.5.0-alpha.1...v2.5.0-alpha.2) (2023-12-22)

### Bug Fixes

* avoid duplicity with linked guest authors ([#1632](#1632)) ([608979c](608979c))
* **modal-checkout:** show order details table with fees ([#1633](#1633)) ([07c0642](07c0642))

### Features

* **modal-checkout:** allow anonymous purchase for registered email ([#1615](#1615)) ([a0040b4](a0040b4))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.5.0-alpha.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Jan 8, 2024
# [2.5.0](v2.4.0...v2.5.0) (2024-01-08)

### Bug Fixes

* avoid duplicity with linked guest authors ([#1632](#1632)) ([608979c](608979c))
* **modal-checkout:** show order details table with fees ([#1633](#1633)) ([07c0642](07c0642))

### Features

* accessibility improvements to the donate block tabs ([#1622](#1622)) ([115e9fb](115e9fb))
* **donate:** support empty value for "other" tier ([#1604](#1604)) ([61ffdbc](61ffdbc))
* **modal-checkout:** allow anonymous purchase for registered email ([#1615](#1615)) ([a0040b4](a0040b4))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants