fix: avoid duplicity with linked guest authors

[leogermani]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Fixes an issue with CAPs linked authors in the Hompepage posts block

How to test the changes in this Pull Request:

1. Create a user and a guest author that share the same name
2. Create one post authored by each of these users
3. Edit the guest author and link them to the user with the same name
4. On master add a new Homepage block to a page and search for the author by it name in the "authors" filter box
5. Confirm you get two results
6. Checkout this branch
7. Confirm you now get only one result
8. Confirm the posts are queried correctly and you get both posts rendered in the block

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1204817890713184

[miguelpeixe]

I was not able to reproduce the issue this is trying to fix. My steps on the master branch were:

• Created a user "Jane Doe"
• Created a guest user "Jane Doe"
• Created a "Jane Doe Post" and selected both users as author
• Edited guest user "Jane Doe" to map to the user with the same name
• Created a homepage posts block to filter only "Jane Doe" and this is what I got:

I edited the created post and was surprised to see that the post no longer had 2 authors. I suspect CAP resolved that when the GA was mapped.

Looking into the original issue in Asana, I believe the problem might be related to how the AutocompleteTokenField behaves.

The component "tokens" are the input labels, so you are not able to select multiple items that share the same name. I believe this should be resolved in 2 ways (not exclusively):

• Append a unique value to the input label, e.g. Jane Doe (#{id})
• Prevent mapped users from rendering as an option, so you get only one option

[leogermani]

Created a homepage posts block to filter only "Jane Doe" and this is what I got:

What should happen is that you will see both Janes in the dropdown. If they are not linked, that's expected, but if they are linked you should see only one.

Good idea adding the ID in the label, I'll have a look. But let me know if you can reproduce the above - and confirm the fix

[miguelpeixe]

I just realized that I completely misinterpreted the PR 😅

I thought it was duplicating posts and not the authors' names. I now understand what to test.

[miguelpeixe]

Now that I understand what to test I can confirm it's working as described!

The addition to the unique value on the label would be nice but not a blocker for this.

[dkoo]

Those sneaky guest authors... 🕵️

[leogermani]

Those sneaky guest authors... 🕵️

oops, sorry for my english. Miguel got it because we speak the same language :)

[miguelpeixe]

I'd never question the use of "duplicity" to mean duplicate 😆

[dkoo]

I got what you meant, too. I actually had to look it up because I wasn't sure if my hunch was correct. 🤣

[matticbot]

🎉 This PR is included in version 2.5.0-alpha.2 🎉

The release is available on:

• npm package (@alpha dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 2.5.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀