-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(modal-checkout): custom coupon form #1629
feat(modal-checkout): custom coupon form #1629
Conversation
…custom-coupon-form
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:chefkiss:
Do you think it's ok to modify the class name and potentially lose support for other plugins customizations on this form? I think it's fine, just confirming
It's something to keep an eye out for. I'm not aware of plugins that replace the coupon behavior. It's worth noting that the code that this takes inspiration from, to be as close to the original behavior as possible, is 9 years old and is not exactly "hookable" to be extended. We'd be using such a hook if there was any 😅 . So I'd say it's safe to assume it shouldn't conflict with anything. |
🎉 This PR is included in version 3.0.0-epic-ras-acc.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.1.0-epic-ras-acc.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.2.0-epic-ras-acc.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.3.0-epic-ras-acc.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
Requires #1602.
Implements a custom coupon form handling so it doesn't inherit Woo's default UI handling of the form. The custom handling is implemented by changing the class name of the form.
How to test the changes in this Pull Request:
Other information: