-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ras-acc): support shipping, custom fields, and order notes in modal checkout #1626
Conversation
I'm not sure why the SCSS lint is failing...those lines are unchanged and also have |
It didn't quite work for me. I set up the testing slightly different. I have two shipping zones, each of them with only one method available
When I set the shipping address to Brazil, I still see the summary with "Frete grátis" (free shipping" there. When I set it to the US, I also see the summary, as expected. EDIT: Apparently the method to retrieve the shipping methods return all shipping methods, and not only those related to the current shipping zone. |
Ah, that's a good catch. a4ca300 fixes the logic so that it only considers shipping methods that apply to the current cart transaction. |
🎉 This PR is included in version 3.0.0-epic-ras-acc.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.1.0-epic-ras-acc.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.2.0-epic-ras-acc.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.3.0-epic-ras-acc.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
Adds support for conditionally showing the order summary for a shippable product only if shipping might incur additional fees on top of the of the order subtotal.
Also adds support for the new features introduced in Automattic/newspack-plugin#2800 to show different billing fields for donations vs. non-donation transactions, and to show order notes in either case.
How to test the changes in this Pull Request:
Check out this branch and Automattic/newspack-plugin#2800.
Conditional order summary
Custom billing fields and order notes
See testing instructions in Automattic/newspack-plugin#2800.
Other information: