Refresh tests, up minimum WP version #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wp-test-utils includes utilities specifically for WordPress-related testing. This will help in future changes to tests.
As of PHPUnit 9.1.0, support for test file names which do not match the class name of the test class within, is deprecated. Support is expected to be removed completely in a future PHPUnit version. Effectively, this means that PHPUnit expects PSR4 to be followed for test classes. While this class is not yet a true TestCase that test classes extend from, it will be, so the naming is taking that into account.
No need to manually require it on each test class.
Add code coverage generation by default as well, so flip the Composer commands for when it’s not needed.
By having the class that contained the helper methods, into a true TestCase that test classes extend, then we simplify the test code in several ways.
- Replace nested dirname() calls - Remove unnecessary local variables - Replace qualifiers with an import - Unwrap unnecessary typecast - Use strpos() instead of substr() - Use instanceof instead of is_a() - Update DocBlocks - Use decrement operator - Replace misused foreach() with array_sum() - Declare closure static - Declare access modifiers - Declare return types where possible - Add parameter and property types - Use more appropriate assertions - Improve regular expression - Remove unnecessary time() argument from strotime() calls - Add more entropy to uniqid() calls - Remove unused code
Refresh the intregrations CI config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernise the structure of the tests. No fundamental changes or new tests, but they are now in a better position to be reviewed and added to as needed.
Updates the minimum WP version, and the corresponding PHP versions tested.
See the individual commits for a clearer understanding of the steps taken.