Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding custom hook for generated xml properties #177

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

elysium001
Copy link
Contributor

@elysium001 elysium001 commented Nov 29, 2023

Feature: Sitemap Generation Hook

Description:

This pull request introduces a new action hook, msm_sitemap_generated, triggered after a sitemap has been generated. This hook provides developers with a convenient entry point to perform additional actions, such as pinging search engines, after the creation of a sitemap.

This enhancement provides flexibility for developers to extend and customize the sitemap generation process based on their specific needs.

UPDATE
After further review, appending the xml and total_url_count values to the existing hooks msm_update_sitemap_post and msm_insert_sitemap_post makes the most sense.

@GaryJones
Copy link
Contributor

Instead of adding a new hook, could the generated XML and total_url_count not just be added to the msm_update_sitemap_post and msm_insert_sitemap_post hook instances, since they happen right before the proposed new action hook spot?

@elysium001 elysium001 merged commit b23cf6a into main Dec 1, 2023
2 of 40 checks passed
@elysium001 elysium001 deleted the add/proposal-hook-to-expose-generated-xml branch December 1, 2023 17:37
@GaryJones GaryJones added this to the 1.5.0 milestone Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants