-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(NODE-6505): CI Setup for Encryption Support #15139
Conversation
lint typo lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments overall. I wasn't able to run this end-to-end locally without resorting to hacks, but if it works fine in GitHub Actions then that's good enough for me.
8ec6cef
to
7cd83f6
Compare
readd dependency readd dependency lint readd dependency readd dependency fix dep fix dep2 fix dep2 fix dep3 fix dep4 fix dep5 fix dep6
e8fa19e
to
06ffdea
Compare
package.json
Outdated
@@ -104,6 +104,7 @@ | |||
"test-deno": "deno run --allow-env --allow-read --allow-net --allow-run --allow-sys --allow-write ./test/deno.js", | |||
"test-rs": "START_REPLICA_SET=1 mocha --timeout 30000 --exit ./test/*.test.js", | |||
"test-tsd": "node ./test/types/check-types-filename && tsd", | |||
"test-encryption": "bash scripts/configure-cluster-with-encryption.sh && mocha --exit ./test/encryption/*.test.js && npm uninstall mongodb-client-encryption > /dev/null", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this command just run mocha
and move the configure-cluster-with-encryption.sh script to a setup-encryption-test
script? Sometimes you don't want to re-run configure-cluster-with-encryption.sh when running locally, and also it would be great be able to pass command line flags to Mocha.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, made the change!
@vkarpov15 What errors and hacks did you need to get this working locally? Ideally it's trivial for anybody to set up and run just from our tooling 🙂 |
@baileympearson I don't recall exactly, there were some issues with finding a python3 install and needing to set up venv. Nothing is trivial when installing python is involved :) If I run into issues again, I'll do a better job writing them down and let you know. |
Merging this into 8.10. |
Descriptions
This testing framework is being added in to allow for ease of encryption testing in PRs to come.
Add CI configuration to ensure that FLE can be end-to-end tested in the mongoose repo.
Add scripting so users can test locally and understand how the CI configuration works.
Summary of Changes