-
Notifications
You must be signed in to change notification settings - Fork 124
Add entry headline #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add entry headline #473
Conversation
TODO: |
|
||
.liveblog-input-headline { | ||
margin-bottom: .5rem; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file is missing a trailing newline
We're going to try an put together a cleaner PR with our back-end liveblogging, TinyMCE and headline changes. |
@paulschreiber Sounds good. Any eta on when that pr will be done? We just needed headline now, hence why I created this. |
Hopefully @adamsilverstein will have time this week. |
@cain - Excellent, this includes nearly all of the functionality we added for headlines. Here is a screenshot of your branch in action: I noticed one issue: the headline field should be cleared after posting an update. I see we added that in a way that is tied into the TinyMCE integration, see paulschreiber@d04df91 I'll try to work on a more decoupled approach that we can include here. |
@adamsilverstein Awesome! Thanks for fixing it up 😄 Do we need to rebuild again? And shall I close this pr? |
Yes, sorry i usually omit built files out of habit to avoid merge conflicts. i'll add those. yes, you can close this pr. |
This is just a pr I created from https://github.com/paulschreiber/liveblog/pull/17/files Just cleaned up a little and some styling changes that were specific to fivethirtyeight
Code stolen from @paulschreiber @adamsilverstein