Skip to content

Add entry headline #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add entry headline #473

wants to merge 2 commits into from

Conversation

cain
Copy link
Contributor

@cain cain commented May 29, 2018

screen shot 2018-05-28 at 6 19 30 pm

screen shot 2018-05-29 at 11 13 21 am

This is just a pr I created from https://github.com/paulschreiber/liveblog/pull/17/files Just cleaned up a little and some styling changes that were specific to fivethirtyeight

Code stolen from @paulschreiber @adamsilverstein

@cain
Copy link
Contributor Author

cain commented May 29, 2018

TODO: need to rebuild app.js


.liveblog-input-headline {
margin-bottom: .5rem;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is missing a trailing newline

@paulschreiber
Copy link
Contributor

We're going to try an put together a cleaner PR with our back-end liveblogging, TinyMCE and headline changes.

@cain
Copy link
Contributor Author

cain commented May 29, 2018

@paulschreiber Sounds good. Any eta on when that pr will be done?

We just needed headline now, hence why I created this.

@cain cain force-pushed the feature/headline branch from a279227 to 14988bc Compare May 29, 2018 04:00
@paulschreiber
Copy link
Contributor

Hopefully @adamsilverstein will have time this week.

@adamsilverstein
Copy link

@cain -

Excellent, this includes nearly all of the functionality we added for headlines.

Here is a screenshot of your branch in action:

I noticed one issue: the headline field should be cleared after posting an update.

I see we added that in a way that is tied into the TinyMCE integration, see paulschreiber@d04df91

I'll try to work on a more decoupled approach that we can include here.

@adamsilverstein
Copy link

@cain I added the field clearing in #474 which builds off this PR since I can't edit this PR directly

Let me know if you have any questions.

@cain
Copy link
Contributor Author

cain commented May 30, 2018

@adamsilverstein Awesome! Thanks for fixing it up 😄

Do we need to rebuild again? And shall I close this pr?

@adamsilverstein
Copy link

Do we need to rebuild again? And shall I close this pr?

Yes, sorry i usually omit built files out of habit to avoid merge conflicts. i'll add those.

yes, you can close this pr.

@cain cain closed this May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants