Forms: Fix form submissions across pages that have pagination applied #41407

enejb · 2025-01-29T22:46:20Z

Currently if you create a page and split it up using the block or code.
Forms on pages other then the first one will not work. See issue #41334.

Proposed changes:

Add a hidden page field that lets the form know what page we are on.
Update the links that appear in the email as well as the form reponses linking to the correct page form.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

no

Testing instructions:

Load this PR.
Create a page with multiple pages.
Place forms across multiple pages.
Notice that you are able to submit each of the posts across the different pages.

github-actions · 2025-01-29T22:47:07Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/form-submit-miulti-page branch.

To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack fix/form-submit-miulti-page

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-01-29T22:47:30Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Choose a review path based on your changes:
- A. Team Review: add the "[Status] Needs Team Review" label
  - For most changes, including minor cross-team impacts.
  - Example: Updating a team-specific component or a small change to a shared library.
- B. Crew Review: add the "[Status] Needs Review" label
  - For significant changes to core functionality.
  - Example: Major updates to a shared library or complex features.
- C. Both: Start with Team, then request Crew
  - For complex changes or when you need extra confidence.
  - Example: Refactor affecting multiple systems.
Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
WoA releases happen weekly.
Releases to self-hosted sites happen monthly. The next release is scheduled for none scheduled (scheduled code freeze on undefined).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

github-actions · 2025-01-29T22:54:49Z

Code Coverage Summary

Coverage changed in 4 files.

File	Coverage	Δ%	Δ Uncovered
projects/packages/forms/src/contact-form/class-contact-form-plugin.php	111/836 (13.28%)	-0.10%	6 💔
projects/packages/forms/src/contact-form/class-contact-form.php	530/760 (69.74%)	-0.36%	6 💔
projects/packages/forms/src/contact-form/class-admin.php	0/778 (0.00%)	0.00%	-3 💚
projects/packages/forms/src/class-wpcom-rest-api-v2-endpoint-forms.php	0/289 (0.00%)	0.00%	-5 💚

Full summary · PHP report · JS report

projects/packages/forms/src/contact-form/class-contact-form.php

projects/packages/forms/src/contact-form/class-contact-form-plugin.php

edanzer

I duplicated the original issue on trunk, and confirmed that the issue is fully resolved with this PR. Forms on paginated posts now submit accurately.

The code changes seem to make sense. Added a few notes. I still lack some context on the surrounding code and logic, and was trying to think through backwards compatibility issues or edge cases in how pagination works. I can't identify specific concerns other than those I've already commented on.

enejb · 2025-01-30T20:25:08Z

@edanzer Can you take another look? I addressed all the issue you found. :)

edanzer · 2025-01-31T20:03:13Z

projects/packages/forms/src/contact-form/class-admin.php

@@ -774,7 +780,7 @@ public function grunion_manage_post_column_response( $post ) {
 			echo '<div class="feedback_response__item-value">' . esc_html( $content_fields['_feedback_ip'] ) . '</div>';
 		}
 		echo '<div class="feedback_response__item-key">' . esc_html__( 'Source', 'jetpack-forms' ) . '</div>';
-		echo '<div class="feedback_response__item-value"><a href="' . esc_url( get_permalink( $post->post_parent ) ) . '" target="_blank" rel="noopener noreferrer">' . esc_html( get_permalink( $post->post_parent ) ) . '</a></div>';
+		echo '<div class="feedback_response__item-value"><a href="' . esc_url( $url ) . '" target="_blank" rel="noopener noreferrer">' . esc_html( $url ) . '</a></div>';


I think changes in this file are new since last time I reviewed. Good to include. Links under Feedback now link to the correct page where the form submission originated.

edanzer

Retested and still working great. Issues addressed. Good addition to update links in the Feedback list so they go to right page.

lezama · 2025-02-03T14:02:58Z

projects/packages/forms/src/contact-form/class-contact-form.php

@@ -123,7 +123,7 @@ public function __construct( $attributes, $content = null ) {
 			if ( ! isset( $attributes['id'] ) ) {
 				$attributes['id'] = '';
 			}
-			$attributes['id'] = $attributes['id'] . '-' . ( count( self::$forms ) + 1 );
+			$attributes['id'] = $attributes['id'] . '-' . ( count( self::$forms ) + 1 ) . '-' . $page;


page isn't an object here? should we use https://developer.wordpress.org/reference/functions/get_the_id/ instead?

$page is a WP global that is a number and tells WP that page to show.

This Pr adds support for form processing across multiple pages

simison · 2025-02-04T08:37:53Z

rebased

simison

Did a basic test, and this seems to work well:

Two forms separated by a page break
Two forms on a single page without page break
Three forms, first and 2nd separated by page break

Everything submits correctly and multiple forms appearing on the same page get individual IDs.

I noticed that when two forms are separated by page break, first from on both pages gets ID by page ID id="contact-form-950", i.e. there are two forms with the same ID on the "same page", just separated by the page break. Not an issue now and things still work as we intended, but this just highlights how we need to later work on true unique IDs.

Correct source URL shows up in the email as well:

simison · 2025-02-04T09:00:44Z

This entry_page appearing in the form response looks like it doesn't belong. It can be removed entirely, or if needed, it could be moved to "meta" section:

In the classic view, I don't see it:

I do see it in the export:

enejb · 2025-02-05T22:04:47Z

Good catch on the entry_page will work on removing this from the export and the new field.

enejb · 2025-02-05T22:55:16Z

@simison Can you take another look when you have the chance. Thank you!

simison

Tests well now!

enejb added [Type] Bug When a feature is broken and / or not performing as intended [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Team Review Your teammate needs to review this PR. [Package] Forms labels Jan 29, 2025

enejb requested a review from a team January 29, 2025 22:46

enejb self-assigned this Jan 29, 2025

github-actions bot added [Feature] Contact Form [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Jan 29, 2025

enejb mentioned this pull request Jan 29, 2025

Form Block: Only the first form works if multiple forms have page breaks in between #41334

Closed

simison changed the title ~~Forms: Fix form submittions across pages that have pagination implemented.~~ Forms: Fix form submissions across pages that have pagination applied Jan 30, 2025

edanzer reviewed Jan 30, 2025

View reviewed changes

projects/packages/forms/src/contact-form/class-contact-form.php Show resolved Hide resolved

edanzer reviewed Jan 30, 2025

View reviewed changes

projects/packages/forms/src/contact-form/class-contact-form.php Show resolved Hide resolved

edanzer reviewed Jan 30, 2025

View reviewed changes

projects/packages/forms/src/contact-form/class-contact-form-plugin.php Show resolved Hide resolved

edanzer previously approved these changes Jan 30, 2025

View reviewed changes

enejb dismissed edanzer’s stale review via 09f25e0 January 30, 2025 20:18

enejb force-pushed the fix/form-submit-miulti-page branch from ffb899a to 09f25e0 Compare January 30, 2025 20:18

simison requested a review from a team January 31, 2025 13:40

edanzer reviewed Jan 31, 2025

View reviewed changes

edanzer previously approved these changes Jan 31, 2025

View reviewed changes

lezama reviewed Feb 3, 2025

View reviewed changes

enejb added 5 commits February 4, 2025 10:37

Forms: Add new page support for forms

a4a2f67

This Pr adds support for form processing across multiple pages

changelog

dd37dc8

sanitize with absint instead of sanitize_text_field

439f95a

guard against invalid $postdata

c9a72ad

Store entry_page and use in in there permalink

1f84eb8

simison force-pushed the fix/form-submit-miulti-page branch from 09f25e0 to 1f84eb8 Compare February 4, 2025 08:37

simison previously approved these changes Feb 4, 2025

View reviewed changes

Consoludate all the non printable fields

e22633e

enejb dismissed stale reviews from simison and edanzer via e22633e February 5, 2025 22:52

simison approved these changes Feb 6, 2025

View reviewed changes

simison added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Team Review Your teammate needs to review this PR. labels Feb 6, 2025

enejb merged commit 1e3c985 into trunk Feb 6, 2025
65 checks passed

enejb deleted the fix/form-submit-miulti-page branch February 6, 2025 20:00

github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 6, 2025

zinigor added this to the jetpack/14.4 milestone Feb 19, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Forms: Fix form submissions across pages that have pagination applied #41407

Forms: Fix form submissions across pages that have pagination applied #41407

enejb commented Jan 29, 2025

github-actions bot commented Jan 29, 2025 •

edited

Loading

github-actions bot commented Jan 29, 2025 •

edited

Loading

github-actions bot commented Jan 29, 2025 •

edited

Loading

edanzer left a comment

enejb commented Jan 30, 2025

edanzer Jan 31, 2025

edanzer left a comment

lezama Feb 3, 2025

enejb Feb 3, 2025

simison commented Feb 4, 2025

simison left a comment •

edited

Loading

simison commented Feb 4, 2025 •

edited

Loading

enejb commented Feb 5, 2025

enejb commented Feb 5, 2025

simison left a comment

Forms: Fix form submissions across pages that have pagination applied #41407

Forms: Fix form submissions across pages that have pagination applied #41407

Conversation

enejb commented Jan 29, 2025

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

github-actions bot commented Jan 29, 2025 • edited Loading

github-actions bot commented Jan 29, 2025 • edited Loading

github-actions bot commented Jan 29, 2025 • edited Loading

Code Coverage Summary

edanzer left a comment

Choose a reason for hiding this comment

enejb commented Jan 30, 2025

edanzer Jan 31, 2025

Choose a reason for hiding this comment

edanzer left a comment

Choose a reason for hiding this comment

lezama Feb 3, 2025

Choose a reason for hiding this comment

enejb Feb 3, 2025

Choose a reason for hiding this comment

simison commented Feb 4, 2025

simison left a comment • edited Loading

Choose a reason for hiding this comment

simison commented Feb 4, 2025 • edited Loading

enejb commented Feb 5, 2025

enejb commented Feb 5, 2025

simison left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 29, 2025 •

edited

Loading

github-actions bot commented Jan 29, 2025 •

edited

Loading

github-actions bot commented Jan 29, 2025 •

edited

Loading

simison left a comment •

edited

Loading

simison commented Feb 4, 2025 •

edited

Loading