Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social | Enable media sharing for WPCOM Business plan #41355

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

manzoorwanijk
Copy link
Member

@manzoorwanijk manzoorwanijk commented Jan 28, 2025

Proposed changes:

  • Social | Enable media sharing for WPCOM Business plan

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Apply 171274-ghe-Automattic/wpcom to your sandbox
  • Apply this PR to your sandbox on top of the above WPCOM PR instead of on trunk
  • Point the public-api and your WPCOM site with a plan lower than Business plan
  • Goto post editor and open Jetpack sidebar
  • Confirm that media sharing is not enabled
  • Now do the same for a site with a Business plan
  • Confirm that media sharing is available
  • Attach a media (try both photo and video)
  • Share the post
  • Confirm that the media sharing works fine
image

Copy link
Contributor

github-actions bot commented Jan 28, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Wpcomsh plugin:

  • Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jan 28, 2025
@manzoorwanijk manzoorwanijk self-assigned this Jan 28, 2025
@manzoorwanijk manzoorwanijk added [Status] Needs Team Review [Type] Feature Development of a new feature and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jan 28, 2025
@manzoorwanijk manzoorwanijk requested a review from a team January 28, 2025 12:29
@manzoorwanijk manzoorwanijk marked this pull request as ready for review January 28, 2025 12:31
@manzoorwanijk manzoorwanijk marked this pull request as draft January 28, 2025 12:53
@manzoorwanijk manzoorwanijk marked this pull request as ready for review February 10, 2025 07:53
Copy link
Contributor

github-actions bot commented Feb 10, 2025

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report

@manzoorwanijk manzoorwanijk marked this pull request as draft February 10, 2025 08:52
@manzoorwanijk manzoorwanijk marked this pull request as ready for review February 10, 2025 10:07
Copy link
Contributor

@gmjuhasz gmjuhasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well for me!

CleanShot 2025-02-10 at 13 33 13 png

@gmjuhasz
Copy link
Contributor

On Atomic I cannot enable the module, I'll try to create another site, Paul if you get to it first good luck

Copy link
Contributor

@gmjuhasz gmjuhasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manzoorwanijk I was able to rsync this to my Atomic site but still not shows the media picker. Maybe we could pair on this tomorrrow

Copy link
Contributor

@pablinos pablinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wpcomsh change doesn't seem to make any difference for me. It's all about having the features updated on the WPCOM side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants