-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launchpad: Add messages anchor in customize welcome message task URL #41320
Launchpad: Add messages anchor in customize welcome message task URL #41320
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
Related to Automattic/wp-calypso#98909.
Proposed changes:
The
calypso_path
for the "Write a welcome message" Launchpad task doesn't have the#messages
anchor and, because it's not there, the page wasn't scrolling down to section relative to the task.Other information:
- [ ] Have you written new tests for your changes, if applicable?- [ ] Have you checked the E2E test CI results, and verified that your changes do not break them?Jetpack product discussion
N/A, but check 36cae-pb.
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
Apply this patch to your sandbox and verify that the Launchpad task now points to the "Messages" section within Newsletter settings.