Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev CLI: Add mirror repo information #41064

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Dev CLI: Add mirror repo information #41064

merged 1 commit into from
Jan 15, 2025

Conversation

kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Jan 14, 2025

Adds a mirror repo so automattic/jetpack-cli will populate.

Secret has already been added.

Proposed changes:

  • Adding the mirror repo information in anticipation of 1.0.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

None yet :)

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Does the project structure linting happy?
  • Post-merge, did it work?

@kraftbj kraftbj added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial [Tools] Development CLI The tools/cli to assist during JP development. Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change. labels Jan 14, 2025
@kraftbj kraftbj requested a review from a team January 14, 2025 20:24
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@kraftbj kraftbj force-pushed the add/auto-publish-cli branch from c20b1c7 to 5c08b69 Compare January 14, 2025 20:31
Copy link
Contributor

@tbradsha tbradsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR itself looks fine. My main concern is one of naming...the package name here confusing, as it has historically referred to the jetpack command:

https://developer.jetpack.com/docs/jetpack-development/jetpack-cli/

I'd prefer something like jpdocker or jpdev, though I'm late to the party.

One small non-blocking nitpick if we go with this naming...I prefer the label to by "Jetpack CLI" instead of "Jetpack Cli".

@kraftbj kraftbj force-pushed the add/auto-publish-cli branch from 5c08b69 to d982000 Compare January 14, 2025 20:39
@kraftbj
Copy link
Contributor Author

kraftbj commented Jan 15, 2025

@tbradsha I renamed the label. IIRC, the garending action will create it if it isn't found (what happened here), but it is case agnostic... so renaming it to Jetpack CLI should persist.

I hear you on naming. I'm also okay deferring. I don't know if this new jp option will solve the right problems and it could be that the existing jetpack becomes part of it (at least in how you use it, if not in code).

@kraftbj kraftbj requested a review from tbradsha January 15, 2025 16:58
Copy link
Contributor

@tbradsha tbradsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kraftbj kraftbj merged commit a3b5512 into trunk Jan 15, 2025
57 checks passed
@kraftbj kraftbj deleted the add/auto-publish-cli branch January 15, 2025 17:05
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JS Package] Jetpack CLI Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change. RNA [Tools] Development CLI The tools/cli to assist during JP development. [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants