-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev CLI: Add mirror repo information #41064
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
c20b1c7
to
5c08b69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR itself looks fine. My main concern is one of naming...the package name here confusing, as it has historically referred to the jetpack
command:
https://developer.jetpack.com/docs/jetpack-development/jetpack-cli/
I'd prefer something like jpdocker
or jpdev
, though I'm late to the party.
One small non-blocking nitpick if we go with this naming...I prefer the label to by "Jetpack CLI" instead of "Jetpack Cli".
5c08b69
to
d982000
Compare
@tbradsha I renamed the label. IIRC, the garending action will create it if it isn't found (what happened here), but it is case agnostic... so renaming it to I hear you on naming. I'm also okay deferring. I don't know if this new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Adds a mirror repo so automattic/jetpack-cli will populate.
Secret has already been added.
Proposed changes:
Other information:
Jetpack product discussion
None yet :)
Does this pull request change what data or activity we track or use?
No.
Testing instructions: