Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social | Fix failure on post save with LinkedIn connection enabled #41000

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

manzoorwanijk
Copy link
Member

Currently, when saving a post with a LinkedIn connection enabled, it fails

Image

Reason: Some string fields are set to false or null.

Proposed changes:

  • Ensure that the connection string fields are such

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to post editor
  • Enabled a LinkedIn connection
  • Save the post
  • Confirm that there is no failure

@manzoorwanijk manzoorwanijk added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Team Review labels Jan 13, 2025
@manzoorwanijk manzoorwanijk requested a review from a team January 13, 2025 13:57
@manzoorwanijk manzoorwanijk self-assigned this Jan 13, 2025
Copy link
Contributor

github-actions bot commented Jan 13, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/social/schema-validation-on-post-save branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack fix/social/schema-validation-on-post-save
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Feature] Publicize Now Jetpack Social, auto-sharing [Package] Publicize labels Jan 13, 2025
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@manzoorwanijk manzoorwanijk force-pushed the fix/social/schema-validation-on-post-save branch from 3fedcfa to cdc9586 Compare January 13, 2025 14:06
@manzoorwanijk manzoorwanijk changed the base branch from social/unified-connections-management to trunk January 13, 2025 14:06
@manzoorwanijk manzoorwanijk changed the title Social | Ensure that the connection string fields are such Social | Fix failure on post save with LinkedIn connection enabled Jan 13, 2025
@manzoorwanijk manzoorwanijk force-pushed the fix/social/schema-validation-on-post-save branch from cdc9586 to afbb4df Compare January 13, 2025 14:17
It says "TypeError PhanCoalescingNeverNull Using non-null (string)($connection_meta['external_id']) of type string as
    | the left hand side of a null coalescing (??) operation. The right hand side may be unnecessary."
Copy link
Contributor

@gmjuhasz gmjuhasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the problem!

@manzoorwanijk manzoorwanijk merged commit 2578d64 into trunk Jan 14, 2025
61 checks passed
@manzoorwanijk manzoorwanijk deleted the fix/social/schema-validation-on-post-save branch January 14, 2025 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Publicize Now Jetpack Social, auto-sharing [Package] Publicize [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants