-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boost: Fix cache bypass patterns not applied from start of URL #40999
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Boost plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@donnchawp raised a good point today. If you want to only exclude the page
/test
from the caching, according to the docs, you would do the following:However, if you do this, you will also exclude anything that contains
/test
in the url. So for example, you would prevent this URL from being cached:/2025/01/01/test/
. This is because the current implementation of bypass pattern matching in Boost is very loose.Proposed changes:
Other information:
Jetpack product discussion
p1736763366014999-slack-C016BBAFHHS
Does this pull request change what data or activity we track or use?
n/a
Testing instructions:
x-jetpack-boost-cache
present. Only cacheable posts/pages have it (with a value of eithermiss
orhit
).Test that exclusions don't behave as expected (old behavior)
test
so the url contains/test
;test
so the url ends with/test
;/test
to the cache exclusion list;Test that there can be duplicates in the cache exclusions
/test
in the list, add the full URL of the page after it and save;/test
twice in the list.Test that exclusions are handled properly (strict matching, new behavior)
Test that there are no duplicates in the cache exclusions
/test
in the list and that the list is saved;/test
in the list.